You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tim Ellison (JIRA)" <ji...@apache.org> on 2009/04/28 19:11:30 UTC
[jira] Resolved: (HARMONY-6185) Javadocs for java.security.* and
javax.security.cert.*
[ https://issues.apache.org/jira/browse/HARMONY-6185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-6185.
----------------------------------
Resolution: Fixed
I agree that the comment isn't particularly helpful to the end users. If anything it is an implementation note for the curious.
I've made a slight modification to the patch, simply to change:
Index: modules/security/src/main/java/common/java/security/Permission.java
===================================================================
--- modules/security/src/main/java/common/java/security/Permission.java (revision 769464)
+++ modules/security/src/main/java/common/java/security/Permission.java (working copy)
@@ -63,8 +63,8 @@
* this permission. The returned actions are in canonical form. For example:
*
* <pre>
- * sp0 = new SocketPermission("www.google.com", "connect,resolve")
- * sp1 = new SocketPermission("www.google.com", "resolve,connect")
+ * sp0 = new SocketPermission("www.example.com", "connect,resolve")
+ * sp1 = new SocketPermission("www.example.com", "resolve,connect")
* sp0.getActions().equals(sp1.getActions()) //yields true
* </pre>
*
so the code remains 'generic'.
FYI I spotted a few places where the 'spec_ref' tags still exist in the security module. I'll go and fix them after this commit.
The patch was applied to the SECURITY module at repo revision r769463.
> Javadocs for java.security.* and javax.security.cert.*
> ------------------------------------------------------
>
> Key: HARMONY-6185
> URL: https://issues.apache.org/jira/browse/HARMONY-6185
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: SVN Revision: 769151
> Reporter: Jesse Wilson
> Assignee: Tim Ellison
> Priority: Minor
> Fix For: 5.0M10
>
> Attachments: Security_Javadoc_from_Android.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Improvements to security Javadocs from Android.
> http://developer.android.com/reference/java/security/package-summary.html
> http://developer.android.com/reference/javax/security/cert/package-summary.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.