You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/07 21:04:06 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #12812: ARROW-16131 [C++] support saving and retrieving custom metadata in batches for IPC file

westonpace commented on code in PR #12812:
URL: https://github.com/apache/arrow/pull/12812#discussion_r845559633


##########
cpp/src/arrow/ipc/writer.cc:
##########
@@ -263,6 +263,14 @@ class RecordBatchSerializer {
     out_->body_length = offset - buffer_start_offset_;
     DCHECK(bit_util::IsMultipleOf8(out_->body_length));
 
+    // copy given record batch's schema metadata to the serializer for serialization
+    auto const &metadata = batch.schema()->metadata();

Review Comment:
   I think I agree.  This would make it too easy to write an inefficient file that contains a lot of duplicate metadata.  Adding an optional metadata field to the `WriteTable` method makes sense.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org