You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/09/16 18:04:40 UTC
[commons-bcel] branch master updated (974c435 -> 41a541a)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git.
from 974c435 More lambdas, less boilerplate.
new 8b14aa3 Update commons-parent from 48 to 49.
new 41a541a Fix checkstyle violations WRT parens.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
pom.xml | 11 ++++++++++-
src/main/java/org/apache/bcel/classfile/Module.java | 2 +-
src/main/java/org/apache/bcel/classfile/ModuleRequires.java | 2 +-
3 files changed, 12 insertions(+), 3 deletions(-)
[commons-bcel] 02/02: Fix checkstyle violations WRT parens.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
commit 41a541a0cf01ef51c118cfde7dca2b48ef31645d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Sep 16 14:04:11 2019 -0400
Fix checkstyle violations WRT parens.
---
src/main/java/org/apache/bcel/classfile/Module.java | 2 +-
src/main/java/org/apache/bcel/classfile/ModuleRequires.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/bcel/classfile/Module.java b/src/main/java/org/apache/bcel/classfile/Module.java
index a0a9d62..024f876 100644
--- a/src/main/java/org/apache/bcel/classfile/Module.java
+++ b/src/main/java/org/apache/bcel/classfile/Module.java
@@ -191,7 +191,7 @@ public final class Module extends Attribute {
buf.append("Module:\n");
buf.append(" name: ") .append(cp.getConstantString(module_name_index, Const.CONSTANT_Module).replace('/', '.')).append("\n");
buf.append(" flags: ") .append(String.format("%04x", module_flags)).append("\n");
- final String version = (module_version_index == 0 ? "0" : cp.getConstantString(module_version_index, Const.CONSTANT_Utf8));
+ final String version = module_version_index == 0 ? "0" : cp.getConstantString(module_version_index, Const.CONSTANT_Utf8);
buf.append(" version: ") .append(version).append("\n");
buf.append(" requires(").append(requires_table.length).append("):\n");
diff --git a/src/main/java/org/apache/bcel/classfile/ModuleRequires.java b/src/main/java/org/apache/bcel/classfile/ModuleRequires.java
index 136a227..2d5d80b 100644
--- a/src/main/java/org/apache/bcel/classfile/ModuleRequires.java
+++ b/src/main/java/org/apache/bcel/classfile/ModuleRequires.java
@@ -94,7 +94,7 @@ public final class ModuleRequires implements Cloneable, Node {
final String module_name = constant_pool.constantToString(requires_index, Const.CONSTANT_Module);
buf.append(Utility.compactClassName(module_name, false));
buf.append(", ").append(String.format("%04x", requires_flags));
- final String version = (requires_version_index == 0 ? "0" : constant_pool.getConstantString(requires_version_index, Const.CONSTANT_Utf8));
+ final String version = requires_version_index == 0 ? "0" : constant_pool.getConstantString(requires_version_index, Const.CONSTANT_Utf8);
buf.append(", ").append(version);
return buf.toString();
}
[commons-bcel] 01/02: Update commons-parent from 48 to 49.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
commit 8b14aa3e2f4690aba1f770b05f668b1726c2189b
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Sep 16 14:03:26 2019 -0400
Update commons-parent from 48 to 49.
---
pom.xml | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index 4359256..5040876 100644
--- a/pom.xml
+++ b/pom.xml
@@ -27,7 +27,7 @@
<parent>
<groupId>org.apache.commons</groupId>
<artifactId>commons-parent</artifactId>
- <version>48</version>
+ <version>49</version>
</parent>
<groupId>org.apache.bcel</groupId>
@@ -348,6 +348,15 @@
</parameter>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.github.spotbugs</groupId>
+ <artifactId>spotbugs-maven-plugin</artifactId>
+ <version>${commons.spotbugs.version}</version>
+ <configuration>
+ <threshold>Normal</threshold>
+ <effort>Default</effort>
+ </configuration>
+ </plugin>
</plugins>
</build>