[GitHub] [helix] narendly commented on a change in pull request #642: Fix zk session race condition before creating a live instance

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #642: Fix zk session race condition before creating a live instance
URL: https://github.com/apache/helix/pull/642#discussion_r353571828
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
 ##########
 @@ -568,6 +612,31 @@ public void createEphemeral(final String path, final Object data)
     create(path, data, CreateMode.EPHEMERAL);
   }
 
+  /**
+   * Create a session aware ephemeral node. Given an expected non-zero session id, if the ephemeral
+   * node is successfully created, it is guaranteed to be in the expected session.
+   *
+   * If the expected session is expired, which means the expected session does not match the current
+   * session of ZK connection, the ephemeral node will not be created and HelixException will be
 
 Review comment:
   Consider not using HelixException?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org