[jira] [Commented] (AIRFLOW-2355) Airflow trigger tag parameters in subdag

["Stefan Seelmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515636#comment-16515636 ] 

Stefan Seelmann commented on AIRFLOW-2355:
------------------------------------------

This change has a side-effect. The subdag run and it's task instances are eagerly created, the subdag is immediately set to "RUNNING" state. This means it is immediately visible in the UI (tree view and dagrun view). 

In our case we skip the SubDagOperator base on some conditions. However the subdag run is then still visible in th UI and in "RUNNING" state which looks scary, see attached screenshot. Before there was no subdag run visible at all for skipped subdags.

One option I see is to not set subdags to "RUNNING" state but "NONE". Then it will still be visible in the UI but not as running. Another idea is to try to pass the conf directly in the SubDagOperator.

Otherwise I really like to have the conf available in the subdag. I also like that the subdag uses the same run_id as the main dag. :)

> Airflow trigger tag parameters in subdag
> ----------------------------------------
>
>                 Key: AIRFLOW-2355
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2355
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 1.9.0
>            Reporter: Mohammed Tameem
>            Assignee: Chao-Han Tsai
>            Priority: Blocker
>             Fix For: 1.10.0, 2.0.0
>
>         Attachments: Screenshot_2018-06-18_13-52-41.png
>
>
> The command airflow {color:#8eb021}+_trigger_dag -c "\{'name':'value'}"_+{color} sends conf parameters only to the parent DAG. I'm using SubDags that are dependent on these parameters. And no parameters are recieved by the SubDag.
> From source code of SubDag operator I see that there is no way of passing these trigger parameters to a Subdag.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)