You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "GlutenPerfBot (via GitHub)" <gi...@apache.org> on 2025/03/02 11:02:33 UTC
[PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
GlutenPerfBot opened a new pull request, #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867
Upstream Velox's New Commits:
```txt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867#issuecomment-2692676884
https://github.com/apache/incubator-gluten/issues/6887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
Posted by "jinchengchenghh (via GitHub)" <gi...@apache.org>.
jinchengchenghh commented on code in PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867#discussion_r1977704250
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -152,10 +152,11 @@ WholeStageResultIterator::WholeStageResultIterator(
starts[idx],
lengths[idx],
partitionKeys,
- std::nullopt,
+ std::nullopt /*tableBucketNmae*/,
Review Comment:
tableBucketNmae -> tableBucketName typo
##########
cpp/velox/shuffle/GlutenByteStream.h:
##########
@@ -54,6 +54,8 @@ class GlutenByteInputStream : public ByteInputStream {
/// TODO Remove after refactoring SpillInput.
virtual ~GlutenByteInputStream() = default;
+ std::vector<ByteRange> ranges_;
Review Comment:
What is the usage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW merged PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867#discussion_r1977715557
##########
cpp/velox/shuffle/GlutenByteStream.h:
##########
@@ -54,6 +54,8 @@ class GlutenByteInputStream : public ByteInputStream {
/// TODO Remove after refactoring SpillInput.
virtual ~GlutenByteInputStream() = default;
+ std::vector<ByteRange> ranges_;
Review Comment:
It's due to the velox change
https://github.com/facebookincubator/velox/commit/c560aaf918c9fbaeda7874d03df4ea28bb753d58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867#issuecomment-2692676982
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867#issuecomment-2695487737
@GlutenPerfBot benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867#issuecomment-2693613561
@GlutenPerfBot Benchmark Velox
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-6887][VL] Daily Update Velox Version (2025_03_02) [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #8867:
URL: https://github.com/apache/incubator-gluten/pull/8867#issuecomment-2694352519
@GlutenPerfBot benchmark velox
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org