You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/23 23:34:46 UTC
[GitHub] [arrow] wesm opened a new pull request #7530: ARROW-8934: [C++] Enable `compute::Subtract` with timestamp inputs to return duration
wesm opened a new pull request #7530:
URL: https://github.com/apache/arrow/pull/7530
I also did a little bit of cleaning, moving some stuff into `arrow::compute::internal`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7530: ARROW-8934: [C++] Enable `compute::Subtract` with timestamp inputs to return duration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7530:
URL: https://github.com/apache/arrow/pull/7530#issuecomment-648484942
https://issues.apache.org/jira/browse/ARROW-8934
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on a change in pull request #7530: ARROW-8934: [C++] Enable `compute::Subtract` with timestamp inputs to return duration
Posted by GitBox <gi...@apache.org>.
wesm commented on a change in pull request #7530:
URL: https://github.com/apache/arrow/pull/7530#discussion_r444564799
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##########
@@ -39,7 +40,7 @@ namespace arrow {
namespace compute {
template <typename ArrowType>
-class TestBinaryArithmetics : public TestBase {
+class TestBinaryArithmetic : public TestBase {
Review comment:
"arithmetics" is not correct, so many of the changes in this file are just this rename
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7530: ARROW-8934: [C++] Enable `compute::Subtract` with timestamp inputs to return duration
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7530:
URL: https://github.com/apache/arrow/pull/7530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7530: ARROW-8934: [C++] Enable `compute::Subtract` with timestamp inputs to return duration
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7530:
URL: https://github.com/apache/arrow/pull/7530#issuecomment-648482567
Example use in Python:
```
In [14]: arr = pa.array(pd.date_range('2000-01-01', periods=20))
In [15]: arr2 = pa.array(pd.date_range('2000-01-10', periods=20))
In [16]: pc.subtract(arr, arr2)
Out[16]:
<pyarrow.lib.DurationArray object at 0x7fc0005de0a8>
[
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000,
-777600000000000
]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7530: ARROW-8934: [C++] Enable `compute::Subtract` with timestamp inputs to return duration
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7530:
URL: https://github.com/apache/arrow/pull/7530#issuecomment-648561822
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org