You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/08 16:47:29 UTC
[GitHub] [iceberg] rdblue commented on a change in pull request #3252: Hive: Add tests for HiveCatalog no-arg constructor, setConf, and initialize
rdblue commented on a change in pull request #3252:
URL: https://github.com/apache/iceberg/pull/3252#discussion_r725162940
##########
File path: hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
##########
@@ -118,6 +122,37 @@ public void testCreateTableWithCaching() throws Exception {
}
}
+ @Test
+ public void testNoArgConstructor() throws Exception {
+ Catalog catalog = new HiveCatalog();
+ }
+
+ @Test
+ public void testSetConf() throws Exception {
+ HiveCatalog catalog = new HiveCatalog();
+ Configuration hadoopConfiguration = new Configuration();
+ catalog.setConf(hadoopConfiguration);
+ }
+
+ @Test
+ public void testInitialize() throws Exception {
+
+ HiveCatalog catalog = Mockito.spy(HiveCatalog.class);
+ Configuration mockHadoopConfiguration = Mockito.mock(Configuration.class);
+ CachedClientPool mockCachedClientPool = Mockito.mock(CachedClientPool.class);
+
+ Mockito.doNothing().when(catalog).setConf(any());
+ Mockito.doReturn(mockCachedClientPool).when(catalog)
+ .makeCachedClientPool(any(), any());
+ Mockito.doReturn("test").when(mockHadoopConfiguration).get(any());
+
+ catalog.setConf(mockHadoopConfiguration);
+ catalog.initialize("test", Collections.<String, String>emptyMap());
+
+ Mockito.verify(catalog, Mockito.times(1)).makeCachedClientPool(any(), any());
+ Assert.assertEquals(catalog.name(), "test");
Review comment:
What are you trying to test? It looks like this only tests that a cached client pool is made. I guess that demonstrates that the initialization completed successfully?
I think what you want to test is that creating a HiveCatalog and initializing it without calling setConf will work. Isn't that the case that broke for users? If so, then I'm surprised that `setConf` is called in this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org