You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Benson Margulies (JIRA)" <ji...@apache.org> on 2009/12/11 17:29:18 UTC
[jira] Created: (MAHOUT-218) Update to Junit 4.5
Update to Junit 4.5
-------------------
Key: MAHOUT-218
URL: https://issues.apache.org/jira/browse/MAHOUT-218
Project: Mahout
Issue Type: Task
Components: Utils
Affects Versions: 0.4
Reporter: Benson Margulies
Junit 4.5 is back-compatible with the current 3.x, and allows using the new @annotation scheme. Since the compiler level is set to 1.6, this seems harmless, and I for one would rather write tests in the new pattern.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (MAHOUT-218) Update to Junit 4.5
Posted by Ted Dunning <te...@gmail.com>.
I have largely switched to the new style, but Sean is right that there is
nearly no difference. The only positive differences that I have seen so far
are:
a) inheritance is more flexible since you don't have to explicitly inherit
from TestCase
b) I can remember how to do class level setup versus test level setup better
than I could remember this in older junit.
The only negative I have seen is that you tend to use Assert.assertEquals
instead of assertEquals. No big deal to me. All the tools I use run both
kinds of test interchangeably.
+1 to supporting Benson's urge to test.
On Fri, Dec 11, 2009 at 9:13 AM, Benson Margulies (JIRA) <ji...@apache.org>wrote:
>
> [
> https://issues.apache.org/jira/browse/MAHOUT-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789395#action_12789395]
>
> Benson Margulies commented on MAHOUT-218:
> -----------------------------------------
>
> I'm setting out to help fill the large gap in unit tests for the colt-
> derived code,
> and I am a lot more efficient with the
> new stuff. So I am grateful to be indulged in
> this regard.
>
> > Update to Junit 4.5
> > -------------------
> >
> > Key: MAHOUT-218
> > URL: https://issues.apache.org/jira/browse/MAHOUT-218
> > Project: Mahout
> > Issue Type: Task
> > Components: Utils
> > Affects Versions: 0.4
> > Reporter: Benson Margulies
> > Attachments: up-junit.patch
> >
> >
> > Junit 4.5 is back-compatible with the current 3.x, and allows using the
> new @annotation scheme. Since the compiler level is set to 1.6, this seems
> harmless, and I for one would rather write tests in the new pattern.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
Ted Dunning, CTO
DeepDyve
[jira] Commented: (MAHOUT-218) Update to Junit 4.5
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789385#action_12789385 ]
Sean Owen commented on MAHOUT-218:
----------------------------------
I'm OK with it.
Maybe I'm a luddite or just not getting it, but I have never really understood how to use JUnit 4.x correctly. Every attempt has looked like a lot of work for a more complex, and functionally identical result. You're not proposing changing to the new APIs, so no issue there (though I recall it wasn't entirely backwards compatible somehow...) Just that somehow JUnit 4.x seemed like they took something simple and working and made it complex and overengineered -- when honestly this ought to be a dead simple framework.
Anyway, still, no substantive objection to using the new library.
> Update to Junit 4.5
> -------------------
>
> Key: MAHOUT-218
> URL: https://issues.apache.org/jira/browse/MAHOUT-218
> Project: Mahout
> Issue Type: Task
> Components: Utils
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: up-junit.patch
>
>
> Junit 4.5 is back-compatible with the current 3.x, and allows using the new @annotation scheme. Since the compiler level is set to 1.6, this seems harmless, and I for one would rather write tests in the new pattern.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MAHOUT-218) Update to Junit 4.5
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved MAHOUT-218.
------------------------------
Resolution: Fixed
Fix Version/s: 0.3
Assignee: Benson Margulies
Took the liberty of committing this, and using version 4.7 actually. All tests pass.
> Update to Junit 4.5
> -------------------
>
> Key: MAHOUT-218
> URL: https://issues.apache.org/jira/browse/MAHOUT-218
> Project: Mahout
> Issue Type: Task
> Components: Utils
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Assignee: Benson Margulies
> Fix For: 0.3
>
> Attachments: up-junit.patch
>
>
> Junit 4.5 is back-compatible with the current 3.x, and allows using the new @annotation scheme. Since the compiler level is set to 1.6, this seems harmless, and I for one would rather write tests in the new pattern.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAHOUT-218) Update to Junit 4.5
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MAHOUT-218:
------------------------------------
Attachment: up-junit.patch
> Update to Junit 4.5
> -------------------
>
> Key: MAHOUT-218
> URL: https://issues.apache.org/jira/browse/MAHOUT-218
> Project: Mahout
> Issue Type: Task
> Components: Utils
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: up-junit.patch
>
>
> Junit 4.5 is back-compatible with the current 3.x, and allows using the new @annotation scheme. Since the compiler level is set to 1.6, this seems harmless, and I for one would rather write tests in the new pattern.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAHOUT-218) Update to Junit 4.5
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789395#action_12789395 ]
Benson Margulies commented on MAHOUT-218:
-----------------------------------------
I'm setting out to help fill the large gap in unit tests for the colt- derived code,
and I am a lot more efficient with the
new stuff. So I am grateful to be indulged in
this regard.
> Update to Junit 4.5
> -------------------
>
> Key: MAHOUT-218
> URL: https://issues.apache.org/jira/browse/MAHOUT-218
> Project: Mahout
> Issue Type: Task
> Components: Utils
> Affects Versions: 0.4
> Reporter: Benson Margulies
> Attachments: up-junit.patch
>
>
> Junit 4.5 is back-compatible with the current 3.x, and allows using the new @annotation scheme. Since the compiler level is set to 1.6, this seems harmless, and I for one would rather write tests in the new pattern.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.