You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by cm...@apache.org on 2016/11/22 14:00:01 UTC

wicket git commit: WICKET-6285 make NoRecordsToolbar use onConfigure/setVisible instead of overriding isVisible

Repository: wicket
Updated Branches:
  refs/heads/master 820a6c0cc -> 0b71bd97b


WICKET-6285 make NoRecordsToolbar use onConfigure/setVisible instead of overriding isVisible


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0b71bd97
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0b71bd97
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0b71bd97

Branch: refs/heads/master
Commit: 0b71bd97b4873eeccb029d00227ba5efef373de8
Parents: 820a6c0
Author: Carl-Eric Menzel <cm...@apache.org>
Authored: Mon Nov 7 13:00:51 2016 +0100
Committer: Carl-Eric Menzel <cm...@wicketbuch.de>
Committed: Tue Nov 22 14:22:05 2016 +0100

----------------------------------------------------------------------
 .../markup/html/repeater/data/table/NoRecordsToolbar.java    | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/0b71bd97/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NoRecordsToolbar.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NoRecordsToolbar.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NoRecordsToolbar.java
index bd89098..6476a49 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NoRecordsToolbar.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/data/table/NoRecordsToolbar.java
@@ -79,13 +79,11 @@ public class NoRecordsToolbar extends AbstractToolbar
 
 	/**
 	 * Only shows this toolbar when there are no rows
-	 * 
-	 * @see org.apache.wicket.Component#isVisible()
 	 */
 	@Override
-	public boolean isVisible()
+	protected void onConfigure()
 	{
-		return getTable().getRowCount() == 0;
+		super.onConfigure();
+		setVisible(getTable().getRowCount() == 0);
 	}
-
 }