[GitHub] rhtyd commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance

[gi...@git.apache.org]

rhtyd commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r129536226
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -2051,6 +2066,8 @@ So if getMinSpeed() returns null we fall back to getSpeed().
         devices.addDevice(new ChannelDef(_qemuGuestAgentSocketName, ChannelDef.ChannelType.UNIX,
                           new File(_qemuSocketsPath + "/" + vmTO.getName() + "." + _qemuGuestAgentSocketName)));
 
+        devices.addDevice(new WatchDogDef(_watchDogAction, _watchDogModel));
 
 Review comment:
   @wido the default action `NONE` is acceptable as adding a watchdog device that might possible reset the instance is not acceptable for everyone. Also, can there be a case where the default watchdog model `I6300ESB` is not available, in which case can we initialize this as null and add the device only when _watchDogModel is not null and read options from agent.properties file /cc @DaanHoogland @nvazquez @ustcweizhou @remibergsma what do you think?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services