You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by sagelywizard <gi...@git.apache.org> on 2016/03/30 05:10:07 UTC
[GitHub] couchdb-couch pull request: Add capability for compaction on local...
GitHub user sagelywizard opened a pull request:
https://github.com/apache/couchdb-couch/pull/157
Add capability for compaction on local update
Prior to this commit, there was no functionality for a custom compactor
to know if the local database had been updated. This commit adds a
local_updated event, which will inform custom compactors when the local
tree has been updated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sagelywizard/couchdb-couch compact-local
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit 176401b666b4d89b109340d4bcc04486308d2692
Author: Benjamin Bastian <be...@gmail.com>
Date: 2016-03-30T03:06:41Z
Add capability for compaction on local update
Prior to this commit, there was no functionality for a custom compactor
to know if the local database had been updated. This commit adds a
local_updated event, which will inform custom compactors when the local
tree has been updated.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Add capability for compaction on local...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/157#discussion_r57858347
--- Diff: src/couch_db_updater.erl ---
@@ -294,6 +294,10 @@ handle_info({update_docs, Client, GroupedDocs, NonRepDocs, MergeConflicts,
couch_event:notify(Db2#db.name, updated);
true -> ok
end,
+ case NonRepDocs2 of
--- End diff --
can we write this in the style of the previous notification? It's slightly shorter but, more importantly, it's consistent with the surrounding coding style.
if NonRepDocs2 /= [] ->
couch_event:notify(...
true -> ok
end,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Add capability for compaction on local...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Add capability for compaction on local...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/157#discussion_r57858396
--- Diff: src/couch_db_updater.erl ---
@@ -294,6 +294,10 @@ handle_info({update_docs, Client, GroupedDocs, NonRepDocs, MergeConflicts,
couch_event:notify(Db2#db.name, updated);
true -> ok
end,
+ case NonRepDocs2 of
--- End diff --
and it makes the condition we care about obvious
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Add capability for compaction on local...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch/pull/157#issuecomment-203339787
+1 to the idea, I commented on the implementation style I'd prefer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---