You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/06/13 11:41:27 UTC

[GitHub] zeppelin pull request #3018: [ZEPPELIN-3539] Add jceks stored password suppo...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/3018

    [ZEPPELIN-3539] Add jceks stored password support for LDAP

    ### What is this PR for?
    This is to add support for storing password in jceks for LDAP (realm).
    
    If the hadoopSecurityCredentialPath path is present and not empty in the shiro.ini, then the password is read from the keystore file and it need not be stored inside the shiro.ini file.
    
    ### What type of PR is it?
    [Improvement | Feature]
    
    ### Todos
    * [ ] - Add documentation
    
    ### What is the Jira issue?
    * [ZEPPELIN-3539](https://issues.apache.org/jira/browse/ZEPPELIN-3539)
    
    ### How should this be tested?
    Create a keystore file using the hadoop credential command line
    ```
    hadoop credential create ldapRealm.systemPassword -provider jceks://file/user/zeppelin/conf/zeppelin.jceks
    ```
    Change the following values in the Shiro.ini file, and uncomment the line:
    ```
    ldapRealm.hadoopSecurityCredentialPath = jceks://file/user/zeppelin/conf/zeppelin.jceks
    ```
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3539

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3018.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3018
    
----
commit 1428b3d1b2db34d06b07463a39250a8acd83b7f4
Author: Prabhjyot Singh <pr...@...>
Date:   2018-06-13T10:08:27Z

    [ZEPPELIN-3539] Add jceks stored password support for LDAP
    
    Change-Id: Ie675f85706bc3793bdc3072a324e1d566b8c3d63

----


---

[GitHub] zeppelin pull request #3018: [ZEPPELIN-3539] Add jceks stored password suppo...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3018


---

[GitHub] zeppelin issue #3018: [ZEPPELIN-3539] Add jceks stored password support for ...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/3018
  
    Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #3018: [ZEPPELIN-3539] Add jceks stored password support for ...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3018
  
    LGTM


---