You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/04/25 05:26:02 UTC
[GitHub] [guacamole-server] dingweiqings opened a new pull request, #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
dingweiqings opened a new pull request, #380:
URL: https://github.com/apache/guacamole-server/pull/380
### This pr is intended to use mirror when a guy stunk in apt install stage as he build docker image.
- And here is another point, I found that guacamole team use ubuntu as a base image instead of debian . For the code consistency ,the division of ubuntu apt packages(free softwares) are _main ,restricted, universe and multiverse_
Another point is packages impish or security version. For example ,impish release version, it contains _impish(base version) ,impish-updates(update version), impish-security(with security version) ,impish-backports(backup version)._ The last backports version is always not installed as a first choice.
- So I think it is a better name use impish as a grep keyword . And if we enable mirror config ,we shoud add all repo search location.
- It is suggested that security repo should be declared separately for more safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857051130
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
#
# The Debian repository that should be preferred for dependencies (this will be
# added to /etc/apt/sources.list if not already present)
#
# NOTE: Due to limitations of the Docker image build process, this value is
# duplicated in an ARG in the second stage of the build.
#
-ARG UBUNTU_RELEASE=impish-backports
+ARG UBUNTU_RELEASE=impish
Review Comment:
But I have a question . Because I don't see specify version in Dockerfile . I think if the version is not specified , then backports version is always be considered as a backup.
Do you mean this two packages ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#issuecomment-1108522866
@necouchman Code has been updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper closed pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
mike-jumper closed pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
URL: https://github.com/apache/guacamole-server/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857049238
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
#
# The Debian repository that should be preferred for dependencies (this will be
# added to /etc/apt/sources.list if not already present)
#
# NOTE: Due to limitations of the Docker image build process, this value is
# duplicated in an ARG in the second stage of the build.
#
-ARG UBUNTU_RELEASE=impish-backports
+ARG UBUNTU_RELEASE=impish
Review Comment:
Yes , that is the design of software backports version . The backports version contains some new feature . Sorry , I haven't know this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] necouchman commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
necouchman commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r856940840
##########
Dockerfile:
##########
@@ -145,6 +154,8 @@ RUN apt-get update
apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $RUNTIME_DEPENDENCIES && \
apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $(cat "${PREFIX_DIR}"/DEPENDENCIES) && \
rm -rf /var/lib/apt/lists/*
+# Reset /etc/apt/sources.list file
+RUN test -f /etc/apt/sources.list.bak && mv /etc/apt/sources.list.bak /etc/apt/sources.list
Review Comment:
Why reset things? That would seem to add inconsistency between how the image is built and the running system??
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
Review Comment:
Are these the default repository locations? I'm hesitant to override defaults by default, if that makes sense - I don't mind providing a way to specify a mirror, but I'm not sure I like the idea of having a particular mirror be called out, here, unless the admin specifically wants it.
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
#
# The Debian repository that should be preferred for dependencies (this will be
# added to /etc/apt/sources.list if not already present)
#
# NOTE: Due to limitations of the Docker image build process, this value is
# duplicated in an ARG in the second stage of the build.
#
-ARG UBUNTU_RELEASE=impish-backports
+ARG UBUNTU_RELEASE=impish
Review Comment:
This will need some further discussion - we have gone back-and-forth between debian and ubuntu, and between things like debian-stable and what you see, here. There are reasons for this - primarily they come down to the versions of libraries, mainly FreeRDP and libssh2, that are included in these base images, and features that either work or do not work with given versions of the libraries. Is there a particular reason why you want to change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings closed pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings closed pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
URL: https://github.com/apache/guacamole-server/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper commented on pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#issuecomment-1304571655
As of #388 and #389, the guacd Docker image uses the latest version of Alpine Linux and builds its own copies of the various protocol libraries manually, automatically grabbing their latest releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857266441
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
#
# The Debian repository that should be preferred for dependencies (this will be
# added to /etc/apt/sources.list if not already present)
#
# NOTE: Due to limitations of the Docker image build process, this value is
# duplicated in an ARG in the second stage of the build.
#
-ARG UBUNTU_RELEASE=impish-backports
+ARG UBUNTU_RELEASE=impish
Review Comment:
After search in this wiki
https://help.ubuntu.com/community/UbuntuBackports
You are right, There is -t argument in apt install command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857051697
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
#
# The Debian repository that should be preferred for dependencies (this will be
# added to /etc/apt/sources.list if not already present)
#
# NOTE: Due to limitations of the Docker image build process, this value is
# duplicated in an ARG in the second stage of the build.
#
-ARG UBUNTU_RELEASE=impish-backports
+ARG UBUNTU_RELEASE=impish
Review Comment:
And I have tried delete backports repo line in /etc/apt/sources.list ,it still can be installed success. Here is a screenshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857053881
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
#
# The Debian repository that should be preferred for dependencies (this will be
# added to /etc/apt/sources.list if not already present)
#
# NOTE: Due to limitations of the Docker image build process, this value is
# duplicated in an ARG in the second stage of the build.
#
-ARG UBUNTU_RELEASE=impish-backports
+ARG UBUNTU_RELEASE=impish
Review Comment:
So maybe these feature you menthioned above is include in main version ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857048820
##########
Dockerfile:
##########
@@ -145,6 +154,8 @@ RUN apt-get update
apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $RUNTIME_DEPENDENCIES && \
apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $(cat "${PREFIX_DIR}"/DEPENDENCIES) && \
rm -rf /var/lib/apt/lists/*
+# Reset /etc/apt/sources.list file
+RUN test -f /etc/apt/sources.list.bak && mv /etc/apt/sources.list.bak /etc/apt/sources.list
Review Comment:
- I think both is ok，guacd container is not allow to apt install packages for now ,because the run user is guacd.
- After someone install all dependencies , he can run this docker image anywhere.
- At last, I think keep the origin version is better .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857048820
##########
Dockerfile:
##########
@@ -145,6 +154,8 @@ RUN apt-get update
apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $RUNTIME_DEPENDENCIES && \
apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $(cat "${PREFIX_DIR}"/DEPENDENCIES) && \
rm -rf /var/lib/apt/lists/*
+# Reset /etc/apt/sources.list file
+RUN test -f /etc/apt/sources.list.bak && mv /etc/apt/sources.list.bak /etc/apt/sources.list
Review Comment:
- I think both is ok，guacd container is not allow to apt install packages for now ,because the run user is guacd.
- After someone install all dependencies , he can run this docker image anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857051130
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
#
# The Debian repository that should be preferred for dependencies (this will be
# added to /etc/apt/sources.list if not already present)
#
# NOTE: Due to limitations of the Docker image build process, this value is
# duplicated in an ARG in the second stage of the build.
#
-ARG UBUNTU_RELEASE=impish-backports
+ARG UBUNTU_RELEASE=impish
Review Comment:
But I have a question . Because I don't see specify version in Dockerfile . I think if the version is not specified , then backports version is always be considered as a backup. Do you mean this two packages ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857049168
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
Review Comment:
Yes , you are right , it is default . If it run in this code snippet , the case is setting USE_APT_REPOSITORY_MIRROR true or impish-backports repo doesn't exist. How about set USE_APT_REPOSITORY_MIRROR to false. Does it make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] dingweiqings commented on a diff in pull request #380: GUACAMOLE-1589: To apt install software using ubuntu repository is too slow in China
Posted by GitBox <gi...@apache.org>.
dingweiqings commented on code in PR #380:
URL: https://github.com/apache/guacamole-server/pull/380#discussion_r857049168
##########
Dockerfile:
##########
@@ -23,24 +23,30 @@
# The Ubuntu image that should be used as the basis for the guacd image
ARG UBUNTU_BASE_IMAGE=21.10
-
# Use Debian as base for the build
FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
+ARG USE_APT_REPOSITORY_MIRROR=true
+# More faster apt repo
+ARG APT_SOURCE="http://archive.ubuntu.com/ubuntu"
+ARG APT_SECURITY_SOURCE="http://security.ubuntu.com/ubuntu"
Review Comment:
Yes , you are right , it is default . If it run in this code snippet , the case is setting USE_APT_REPOSITORY_MIRROR true or impish-backports repo doesn't exist. How about set USE_APT_REPOSITORY_MIRROR to false? Does it make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org