You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@royale.apache.org by GitBox <gi...@apache.org> on 2020/06/06 00:33:50 UTC

[GitHub] [royale-asjs] mjesteve opened a new pull request #850: Add Font awesome icon type

mjesteve opened a new pull request #850:
URL: https://github.com/apache/royale-asjs/pull/850


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] mjesteve commented on pull request #850: Add Font awesome icon type

Posted by GitBox <gi...@apache.org>.
mjesteve commented on pull request #850:
URL: https://github.com/apache/royale-asjs/pull/850#issuecomment-640093025


   Sorry Carlos, I was not aware. I have updated my fork with the royale fork and then I have messed around when committing the changes but I thought that all that would not go in the commit.
   I have it in mind.
   Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] carlosrovira commented on pull request #850: Add Font awesome icon type

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #850:
URL: https://github.com/apache/royale-asjs/pull/850#issuecomment-640022341


   Hi Maria Jose, please, for next time try to avoid this kind of merge and take a clean branch, since it  makes develop to a dirty branching graph. Thanks :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] carlosrovira commented on pull request #850: Add Font awesome icon type

Posted by GitBox <gi...@apache.org>.
carlosrovira commented on pull request #850:
URL: https://github.com/apache/royale-asjs/pull/850#issuecomment-640182982


   @mjesteve the best is to create a clean branch updated to avoid this king of things
   
   @Harbs thanks, very useful, I was not aware of that option.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] Harbs commented on pull request #850: Add Font awesome icon type

Posted by GitBox <gi...@apache.org>.
Harbs commented on pull request #850:
URL: https://github.com/apache/royale-asjs/pull/850#issuecomment-640113580


   @carlosrovira When you merge, you can select "Squash" which cleans up the graph to show a single commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [royale-asjs] carlosrovira merged pull request #850: Add Font awesome icon type

Posted by GitBox <gi...@apache.org>.
carlosrovira merged pull request #850:
URL: https://github.com/apache/royale-asjs/pull/850


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org