You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 18:22:43 UTC

[GitHub] [arrow] westonpace commented on pull request #13040: ARROW-16426: [C++] Add TeeNode to execution engine

westonpace commented on PR #13040:
URL: https://github.com/apache/arrow/pull/13040#issuecomment-1116417482

   Ah, it seems `MapNode` had not previously ever been used outside of the compute module.  `file_base.cc` is in the datasets module.  You will need to add the appropriate exports to `MapNode`.  This is an unfortunate process that seems to be unique to Windows.  This should be as simple as...
   
   ```
   class ARROW_EXPORT MapNode : public ExecNode {
   ...
   ```
   
   Although exposing things tends to have somewhat infectious consequences.  For example, I'm pretty sure you will then also need to expose `AtomicCounter` since it is referenced by `MapNode`.  However, that should be about it and it makes sense to expose both of those things as they will be generally useful to anyone building `ExecNode` implementations outside of Arrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org