[GitHub] [arrow-datafusion] AssHero commented on a diff in pull request #4260: add ambiguous check for projection

[GitBox <gi...@apache.org>]

AssHero commented on code in PR #4260:
URL: https://github.com/apache/arrow-datafusion/pull/4260#discussion_r1027022413


##########
datafusion/sql/src/planner.rs:
##########
@@ -1124,6 +1126,39 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         // process `from` clause
         let plans = self.plan_from_tables(select.from, ctes, outer_query_schema)?;
         let empty_from = matches!(plans.first(), Some(LogicalPlan::EmptyRelation(_)));
+        // build from schema for unqualifier column ambiguous check
+        // we should get only one field for this unqualifier column from schema.
+        let from_schema = {

Review Comment:
   > Maybe as a follow up PR we could factor this out into a function (as `select_to_plan` is already quite long)
   
   Thanks! @alamb  I'll propose a follow up PR to handle this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org