[jira] [Comment Edited] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

["Gary Yao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649304#comment-16649304 ] 

Gary Yao edited comment on FLINK-5486 at 10/14/18 9:02 AM:
-----------------------------------------------------------

Closed for the same reason as explained [here|https://issues.apache.org/jira/browse/FLINK-4534?focusedCommentId=16550597&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16550597]. Please reopen if you think otherwise.


was (Author: gjy):
Closed for the same reason as explained [here|https://issues.apache.org/jira/browse/FLINK-4534?focusedCommentId=16550597&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16550597].

> Lack of synchronization in BucketingSink#handleRestoredBucketState()
> --------------------------------------------------------------------
>
>                 Key: FLINK-5486
>                 URL: https://issues.apache.org/jira/browse/FLINK-5486
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>    Affects Versions: 1.5.0, 1.4.2, 1.6.0
>            Reporter: Ted Yu
>            Assignee: zhangminglei
>            Priority: Major
>
> Here is related code:
> {code}
>       handlePendingFilesForPreviousCheckpoints(bucketState.pendingFilesPerCheckpoint);
>       synchronized (bucketState.pendingFilesPerCheckpoint) {
>         bucketState.pendingFilesPerCheckpoint.clear();
>       }
> {code}
> The handlePendingFilesForPreviousCheckpoints() call should be enclosed inside the synchronization block. Otherwise during the processing of handlePendingFilesForPreviousCheckpoints(), some entries of the map may be cleared.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)