[GitHub] [spark] cloud-fan commented on a change in pull request #35227: [SPARK-37931][SQL] Quote the column name if needed

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35227:
URL: https://github.com/apache/spark/pull/35227#discussion_r793683152



##########
File path: sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out
##########
@@ -162,8 +162,8 @@ show create table char_tbl3
 struct<createtab_stmt:string>
 -- !query output
 CREATE TABLE default.char_tbl3 (
-  `c` CHAR(5),
-  `v` VARCHAR(6))
+  c CHAR(5),
+  v VARCHAR(6))

Review comment:
       I noticed that the view test in this file still has quotes. `ShowCreateTableCommand` has a branch for view, and we need to update the quoting logic in that branch as well. @Peng-Lei 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org