You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/14 23:18:30 UTC

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #16436: Add sum for boolean type when not built with TVM

haojin2 commented on a change in pull request #16436: Add sum for boolean type when not built with TVM
URL: https://github.com/apache/incubator-mxnet/pull/16436#discussion_r334697720
 
 

 ##########
 File path: tests/python/unittest/test_numpy_op.py
 ##########
 @@ -540,7 +542,7 @@ def is_int(dtype):
                             x_sym = mx.sym.Variable("x").as_np_ndarray()
                             mx_sym = mx.sym.np.sum(x_sym, axis=axis, dtype=dtype, keepdims=keepdims).as_nd_ndarray()
                             check_numeric_gradient(mx_sym, [x.as_nd_ndarray()],
-                                                   numeric_eps=1e-3, rtol=1e-3, atol=1e-4, dtype=_np.float32)
+                                                   numeric_eps=1e-3, rtol=1e-2, atol=1e-3, dtype=_np.float32)
 
 Review comment:
   @DickJC123 @reminisce 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services