You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/02/24 03:51:53 UTC
Review Request 57017: When the error occurs,
the system does not record the error message in RangerServiceService class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57017/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1408
https://issues.apache.org/jira/browse/RANGER-1408
Repository: ranger
Description
-------
When the error occurs, the system does not record the error message in RangerServiceService class
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
Diff: https://reviews.apache.org/r/57017/diff/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 57017: When the error occurs,
the system does not record the error message in RangerServiceService class
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57017/#review167039
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On Feb. 27, 2017, 12:15 p.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57017/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 12:15 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1408
> https://issues.apache.org/jira/browse/RANGER-1408
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When the error occurs, the system does not record the error message in RangerServiceService class
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
>
> Diff: https://reviews.apache.org/r/57017/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57017: When the error occurs,
the system does not record the error message in RangerServiceService class
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57017/
-----------------------------------------------------------
(Updated Feb. 27, 2017, 12:15 p.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1408
https://issues.apache.org/jira/browse/RANGER-1408
Repository: ranger
Description
-------
When the error occurs, the system does not record the error message in RangerServiceService class
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
Diff: https://reviews.apache.org/r/57017/diff/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 57017: When the error occurs,
the system does not record the error message in RangerServiceService class
Posted by Qiang Zhang <zh...@zte.com.cn>.
> On Feb. 27, 2017, 10:04 a.m., Colm O hEigeartaigh wrote:
> > Please make the "Logger" private static final and change the variable name to uppercase.
Ok. I modified and updated the patch. Thanks!
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57017/#review166840
-----------------------------------------------------------
On Feb. 27, 2017, 12:15 p.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57017/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 12:15 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1408
> https://issues.apache.org/jira/browse/RANGER-1408
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When the error occurs, the system does not record the error message in RangerServiceService class
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
>
> Diff: https://reviews.apache.org/r/57017/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 57017: When the error occurs,
the system does not record the error message in RangerServiceService class
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57017/#review166840
-----------------------------------------------------------
Please make the "Logger" private static final and change the variable name to uppercase.
- Colm O hEigeartaigh
On Feb. 24, 2017, 3:51 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57017/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 3:51 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1408
> https://issues.apache.org/jira/browse/RANGER-1408
>
>
> Repository: ranger
>
>
> Description
> -------
>
> When the error occurs, the system does not record the error message in RangerServiceService class
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java 004524b
>
> Diff: https://reviews.apache.org/r/57017/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>