You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Swapnil Bawaskar <sb...@apache.org> on 2016/08/22 21:11:09 UTC
Review Request 51302: GEODE-1768: CI failure:
ResourceManagerDUnitTest.testRemoveDuringKeySet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51302/
-----------------------------------------------------------
Review request for geode.
Repository: geode
Description
-------
- Marked the test as flaky
- added one new assertion
- Improved the assertion error message to help debug
GEODE-1711: PersistentRVVRecoveryDUnitTest.testWriteCorrectVersionToKrf
The exception in this failure was thrown in DiskStoreImpl.checkForFlusherThredTermination(),
which can also throw a DiskAccessException.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 361ac2e2058d536c9e9b9e9b6250289363e2f7dd
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/persistence/PersistentRVVRecoveryDUnitTest.java dc4228c985d4606813c866914bee417e4d3ddc5d
Diff: https://reviews.apache.org/r/51302/diff/
Testing
-------
Thanks,
Swapnil Bawaskar
Re: Review Request 51302: GEODE-1768: CI failure:
ResourceManagerDUnitTest.testRemoveDuringKeySet
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51302/#review146456
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Shu
On Aug. 22, 2016, 9:11 p.m., Swapnil Bawaskar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51302/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 9:11 p.m.)
>
>
> Review request for geode.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Marked the test as flaky
> - added one new assertion
> - Improved the assertion error message to help debug
>
> GEODE-1711: PersistentRVVRecoveryDUnitTest.testWriteCorrectVersionToKrf
>
> The exception in this failure was thrown in DiskStoreImpl.checkForFlusherThredTermination(),
> which can also throw a DiskAccessException.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/cache/management/ResourceManagerDUnitTest.java 361ac2e2058d536c9e9b9e9b6250289363e2f7dd
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/persistence/PersistentRVVRecoveryDUnitTest.java dc4228c985d4606813c866914bee417e4d3ddc5d
>
> Diff: https://reviews.apache.org/r/51302/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapnil Bawaskar
>
>