[isis] branch master updated: ISIS-2856: more deprecations handled (viewer-common)

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 38007c2  ISIS-2856: more deprecations handled (viewer-common)
38007c2 is described below

commit 38007c200901e9add6f8b5724f851fc80e0f7000
Author: Andi Huber <ah...@apache.org>
AuthorDate: Sun Jan 9 13:50:49 2022 +0100

    ISIS-2856: more deprecations handled (viewer-common)
---
 .../model/action/PendingParameterManager.java      | 31 ----------------------
 .../model/components/UiComponentFactory.java       | 10 +------
 2 files changed, 1 insertion(+), 40 deletions(-)

diff --git a/viewers/common/src/main/java/org/apache/isis/viewer/common/model/action/PendingParameterManager.java b/viewers/common/src/main/java/org/apache/isis/viewer/common/model/action/PendingParameterManager.java
deleted file mode 100644
index abb66a6..0000000
--- a/viewers/common/src/main/java/org/apache/isis/viewer/common/model/action/PendingParameterManager.java
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- *  Licensed to the Apache Software Foundation (ASF) under one
- *  or more contributor license agreements.  See the NOTICE file
- *  distributed with this work for additional information
- *  regarding copyright ownership.  The ASF licenses this file
- *  to you under the Apache License, Version 2.0 (the
- *  "License"); you may not use this file except in compliance
- *  with the License.  You may obtain a copy of the License at
- *
- *        http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing,
- *  software distributed under the License is distributed on an
- *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- *  KIND, either express or implied.  See the License for the
- *  specific language governing permissions and limitations
- *  under the License.
- */
-package org.apache.isis.viewer.common.model.action;
-
-import org.apache.isis.core.metamodel.spec.ManagedObject;
-import org.apache.isis.core.metamodel.spec.feature.ObjectActionParameter;
-
-@Deprecated
-public interface PendingParameterManager {
-
-    void setParameterValue(ObjectActionParameter actionParameter, ManagedObject newParamValue);
-
-    void clearParameterValue(ObjectActionParameter actionParameter);
-
-}
diff --git a/viewers/common/src/main/java/org/apache/isis/viewer/common/model/components/UiComponentFactory.java b/viewers/common/src/main/java/org/apache/isis/viewer/common/model/components/UiComponentFactory.java
index e7682fdc..5f2c004 100644
--- a/viewers/common/src/main/java/org/apache/isis/viewer/common/model/components/UiComponentFactory.java
+++ b/viewers/common/src/main/java/org/apache/isis/viewer/common/model/components/UiComponentFactory.java
@@ -31,7 +31,6 @@ import org.apache.isis.commons.internal.base._NullSafe;
 import org.apache.isis.commons.internal.functions._Predicates;
 import org.apache.isis.core.metamodel.facetapi.Facet;
 import org.apache.isis.core.metamodel.facets.object.value.ValueFacet;
-import org.apache.isis.core.metamodel.interactions.managed.InteractionVeto;
 import org.apache.isis.core.metamodel.interactions.managed.ManagedAction;
 import org.apache.isis.core.metamodel.interactions.managed.ManagedFeature;
 import org.apache.isis.core.metamodel.interactions.managed.ManagedParameter;
@@ -140,7 +139,7 @@ public interface UiComponentFactory<B, C> {
             return ((ManagedProperty)managedFeature).checkUsability().isPresent();
         }
 
-        @Deprecated
+        @Deprecated // used by Vaadin Viewer - however, we have bindable models to use instead
         public <T> Optional<T> getFeatureValue(final @Nullable Class<T> type) {
             val managedProperty = (ManagedProperty)managedFeature;
             //TODO do a type check before the cast, so we can throw a more detailed exception
@@ -151,13 +150,6 @@ public interface UiComponentFactory<B, C> {
                     .map(type::cast);
         }
 
-        @Deprecated
-        public Optional<InteractionVeto> setFeatureValue(final Object proposedNewValuePojo) {
-            //TODO we are loosing any fields that are cached within ManagedObject
-            val proposedNewValue = ManagedObject.of(getFeatureTypeSpec(), proposedNewValuePojo);
-            return ((ManagedProperty)managedFeature).modifyProperty(proposedNewValue);
-        }
-
     }