You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by cc...@apache.org on 2016/03/11 19:25:53 UTC
incubator-mynewt-newt git commit: Add some todo (XXX) comments to
implement post-B2.
Repository: incubator-mynewt-newt
Updated Branches:
refs/heads/develop b5743eab4 -> 15b9b591c
Add some todo (XXX) comments to implement post-B2.
Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/commit/15b9b591
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/tree/15b9b591
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/diff/15b9b591
Branch: refs/heads/develop
Commit: 15b9b591cf0df20a31523178e266de68db93ba78
Parents: b5743ea
Author: ccollins at iori.nightmare.heaven <cc...@iori.nightmare-heaven.no-ip.biz>
Authored: Fri Mar 11 10:25:15 2016 -0800
Committer: ccollins at iori.nightmare.heaven <cc...@iori.nightmare-heaven.no-ip.biz>
Committed: Fri Mar 11 10:25:15 2016 -0800
----------------------------------------------------------------------
newt/pkg/localpackage.go | 8 ++++++++
1 file changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/blob/15b9b591/newt/pkg/localpackage.go
----------------------------------------------------------------------
diff --git a/newt/pkg/localpackage.go b/newt/pkg/localpackage.go
index f0dc46b..7c14729 100644
--- a/newt/pkg/localpackage.go
+++ b/newt/pkg/localpackage.go
@@ -73,6 +73,8 @@ type LocalPackage struct {
func NewLocalPackage(r *repo.Repo, pkgDir string) *LocalPackage {
pkg := &LocalPackage{
desc: &PackageDesc{},
+ // XXX: Initialize viper object; clients should not need to check for
+ // nil pointer.
}
pkg.Init(r, pkgDir)
return pkg
@@ -109,6 +111,8 @@ func (pkg *LocalPackage) Desc() *PackageDesc {
func (pkg *LocalPackage) SetName(name string) {
pkg.name = name
+ // XXX: Also set "pkg.name" in viper object (possibly just remove cached
+ // variable from code entirely).
}
func (pkg *LocalPackage) SetBasePath(basePath string) {
@@ -117,10 +121,14 @@ func (pkg *LocalPackage) SetBasePath(basePath string) {
func (pkg *LocalPackage) SetType(packageType interfaces.PackageType) {
pkg.packageType = packageType
+ // XXX: Also set "pkg.type" in viper object (possibly just remove cached
+ // variable from code entirely).
}
func (pkg *LocalPackage) SetDesc(desc *PackageDesc) {
pkg.desc = desc
+ // XXX: Also set desc fields in viper object (possibly just remove cached
+ // variable from code entirely).
}
func (pkg *LocalPackage) SetRepo(r *repo.Repo) {