[GitHub] [spark] Yikun commented on a change in pull request #35819: [SPARK-38524][K8S][TESTS] Fix Volcano `weight` to be positive integer and use `cpu` capability instead

[GitBox <gi...@apache.org>]

Yikun commented on a change in pull request #35819:
URL: https://github.com/apache/spark/pull/35819#discussion_r826518293



##########
File path: resource-managers/kubernetes/integration-tests/src/test/resources/volcano/disable-queue.yml
##########
@@ -19,6 +19,6 @@ kind: Queue
 metadata:
   name: queue
 spec:
-  weight: 0
+  weight: 1
   capability:
-    cpu: "1"
+    cpu: "0.1"

Review comment:
       cap 0 is valid, if capacity <= 0 represents [no limit](https://github.com/volcano-sh/volcano/blob/6ea23412696eb7369e8e3dcf543604a5341058e1/pkg/scheduler/plugins/proportion/proportion.go#L104-L112) in Volcano queue.
   
   This is different with `Weight`, weight is soft constraint to calculate some proportions according to weight value, so `0` bring some unexpected behavior, so it's invalid.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org