You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2023/04/04 19:09:45 UTC
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19690
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
KUDU-1945 Add C++ example for non-unique PK
This patch adds an example C++ file to showcase the main operations
performed on a table having non-unique primary key.
STDOUT of the example:
Created a client connection
Created the schema:
(
non_unique_key INT32 NOT NULL,
auto_incrementing_id INT64 NOT NULL,
int_val INT32 NOT NULL,
PRIMARY KEY (non_unique_key, auto_incrementing_id)
)
Created the table
Inserted some row(s) into a table:
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Demonstrating scanning ...
Scanned some row(s) from table, WHERE non_unique_key = 1:
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
Demonstrating UPDATE ...
Updated row(s), WHERE non_unique_key = 1 AND int_val = 2,\
to int_val = 98
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Updated row(s), WHERE non_unique_key = 2, to int_val = 99
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Updated row(s), WHERE non_unique_key = 2 AND auto_incrementing_id = 5,\
to int_val = 100
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Demonstrating DELETE ...
Deleted row(s), WHERE non_unique_key = 3 AND int_val = 1
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Deleted row(s), WHERE non_unique_key = 2
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted row(s), WHERE non_unique_key = 3 AND auto_incrementing_id = 3
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted a table
Done
Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
---
M examples/cpp/CMakeLists.txt
R examples/cpp/getting_started.cc
A examples/cpp/non_unique_primary_key.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client_examples-test.sh
5 files changed, 390 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/19690/1
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19690
to look at the new patch set (#7).
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
KUDU-1945 Add C++ example for non-unique PK
This patch adds an example based on Kudu C++ client API to showcase the
main operations performed on a table having a non-unique primary key.
STDOUT of the example:
Created a client connection
Created the schema:
(
non_unique_key INT32 NOT NULL,
auto_incrementing_id INT64 NOT NULL,
int_val INT32 NOT NULL,
PRIMARY KEY (non_unique_key, auto_incrementing_id)
)
Created the table
Inserted some row(s) into the table:
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Demonstrating scanning ...
Scanned some row(s) WHERE non_unique_key = 1:
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
Demonstrating UPDATE ...
Updated row(s) WHERE non_unique_key = 1 AND int_val = 2 to int_val = 98
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Updated row(s) WHERE non_unique_key = 2 to int_val = 99
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Updated row(s) WHERE non_unique_key = 2 AND auto_incrementing_id = 5 to\
int_val = 100
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=\
100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Demonstrating DELETE ...
Deleted row(s) WHERE non_unique_key = 3 AND int_val = 1
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=\
100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Deleted row(s) WHERE non_unique_key = 2
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted row(s) WHERE non_unique_key = 3 AND auto_incrementing_id = 3
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted the table
Done
Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
---
M examples/cpp/CMakeLists.txt
A examples/cpp/non_unique_primary_key.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client_examples-test.sh
4 files changed, 381 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/19690/7
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 7
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19690
to look at the new patch set (#4).
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
KUDU-1945 Add C++ example for non-unique PK
This patch adds an example C++ file to showcase the main operations
performed on a table having non-unique primary key.
STDOUT of the example:
Created a client connection
Created the schema:
(
non_unique_key INT32 NOT NULL,
auto_incrementing_id INT64 NOT NULL,
int_val INT32 NOT NULL,
PRIMARY KEY (non_unique_key, auto_incrementing_id)
)
Created the table
Inserted some row(s) into a table:
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Demonstrating scanning ...
Scanned some row(s) from table, WHERE non_unique_key = 1:
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
Demonstrating UPDATE ...
Updated row(s), WHERE non_unique_key = 1 AND int_val = 2,\
to int_val = 98
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Updated row(s), WHERE non_unique_key = 2, to int_val = 99
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Updated row(s), WHERE non_unique_key = 2 AND auto_incrementing_id = 5,\
to int_val = 100
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Demonstrating DELETE ...
Deleted row(s), WHERE non_unique_key = 3 AND int_val = 1
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Deleted row(s), WHERE non_unique_key = 2
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted row(s), WHERE non_unique_key = 3 AND auto_incrementing_id = 3
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted a table
Done
Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
---
M examples/cpp/CMakeLists.txt
A examples/cpp/non_unique_primary_key.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client_examples-test.sh
4 files changed, 380 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/19690/4
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 7
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 16:35:01 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19690
to look at the new patch set (#6).
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
KUDU-1945 Add C++ example for non-unique PK
This patch adds an example based on Kudu C++ client API to showcase the
main operations performed on a table having a non-unique primary key.
STDOUT of the example:
Created a client connection
Created the schema:
(
non_unique_key INT32 NOT NULL,
auto_incrementing_id INT64 NOT NULL,
int_val INT32 NOT NULL,
PRIMARY KEY (non_unique_key, auto_incrementing_id)
)
Created the table
Inserted some row(s) into the table:
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Demonstrating scanning ...
Scanned some row(s) WHERE non_unique_key = 1:
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
Demonstrating UPDATE ...
Updated row(s) WHERE non_unique_key = 1 AND int_val = 2 to int_val = 98
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Updated row(s) WHERE non_unique_key = 2 to int_val = 99
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Updated row(s) WHERE non_unique_key = 2 AND auto_incrementing_id = 5 to\
int_val = 100
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=\
100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Demonstrating DELETE ...
Deleted row(s) WHERE non_unique_key = 3 AND int_val = 1
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=\
100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Deleted row(s) WHERE non_unique_key = 2
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted row(s) WHERE non_unique_key = 3 AND auto_incrementing_id = 3
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted the table
Done
Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
---
M examples/cpp/CMakeLists.txt
A examples/cpp/non_unique_primary_key.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client_examples-test.sh
4 files changed, 380 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/19690/6
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 6:
(26 comments)
http://gerrit.cloudera.org:8080/#/c/19690/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19690/5//COMMIT_MSG@9
PS5, Line 9: based on
> based on Kudu C++ client API
Done
http://gerrit.cloudera.org:8080/#/c/19690/5//COMMIT_MSG@10
PS5, Line 10: a table h
> a non-unique
Done
http://gerrit.cloudera.org:8080/#/c/19690/5//COMMIT_MSG@12
PS5, Line 12: STDOUT of the example:
> nit: update the snippet after addressing review feedback on the example's c
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/CMakeLists.txt
File examples/cpp/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/CMakeLists.txt@21
PS5, Line 21: set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
> Should this stay or this was used only during troubleshooting/debugging pha
Newer IDEs, LSP based completers make heavy use of compile_commands.json.
Users who are building up knowledge about Kudu client will most likely rely on autocomplete, suggestions to play around with the examples. That is why I left this in.
On the other hand, if we are aiming to include only Kudu functional code, I can remove it, no problem.
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
PS5:
> Even if Kudu C++ client API is compatible with C++98, I think that new exam
Absolutely! I just wasn't sure on the positioning between supporting C++98 and using newer C++ features in new examples.
Changed a couple places.
The one place where I left raw pointers is "KuduPredicate* p = table->NewComparisonPredicate(...)", the predicates are used in "scanner.AddConjunctPredicate(...)" <- this takes ownership.
Let me know if this works.
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@68
PS5, Line 68:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@81
PS5, Line 81:
> specified
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@111
PS5, Line 111:
: KUDU_RETURN_NOT_OK(ses
> KUDU_RETURN_NOT_OK(session->Flush())
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@138
PS5, Line 138: // It's necessary to specify the entire set of key columns when updating a particular row.
: // An auto-incrementing column is auto-populated at the serve
> How about:
Done.
Thanks for the clear formulation!
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@145
PS5, Line 145: KUDU_RETURN_NOT_OK(s
> nit: move this inside the 'while' cycle?
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@172
PS5, Line 172:
: KUDU_RETURN_NOT_OK(ses
> nit: could be shorten to KUDU_RETURN_NOT_OK(session->Flush()) ?
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@179
PS5, Line 179: // It's necessary to specify the entire set of key columns when updating a particular row.
: // An auto-incrementing column is auto-populated at the serve
> How about:
Done.
Thanks for the clear formulation!
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@211
PS5, Line 211:
: KUDU_RETURN_NOT_OK(ses
> nit: KUDU_RETURN_NOT_OK(Flush())
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@219
PS5, Line 219: FATAL
> ERROR
To run any of the C++ client apps, one has to provide the host address.
IIUC there is no point in continuing in the execution, as it will just exit with a can't connect to kudu master error at the first point.
I think FATAL is reasonable here, but if you think that even after this consideration, the ERROR is better suited, I'm happy to change over.
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@247
PS5, Line 247: t
> the
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@253
PS5, Line 253: WHERE non_un
> nit: drop this part
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@277
PS5, Line 277:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@278
PS5, Line 278:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@292
PS5, Line 292:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@293
PS5, Line 293:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@312
PS5, Line 312:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@314
PS5, Line 314:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@332
PS5, Line 332:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@346
PS5, Line 346:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@364
PS5, Line 364:
> nit: drop the comma
Done
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@371
PS5, Line 371: t
> the
Done
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Apr 2023 13:52:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 7: Verified+1
(2 comments)
unrelated test failure in LogRollingITest.TestLogCleanupOnStartup
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/CMakeLists.txt
File examples/cpp/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/CMakeLists.txt@21
PS5, Line 21: set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
> Newer IDEs, LSP based completers make heavy use of compile_commands.json.
Sure -- let's keep it around if it's useful.
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@219
PS5, Line 219: ERROR
> Sorry about that, thanks for the clarification!
No problem. Thanks for the update!
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 7
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 16:34:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 5:
(29 comments)
Almost there!
http://gerrit.cloudera.org:8080/#/c/19690/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19690/5//COMMIT_MSG@9
PS5, Line 9: C++ file
based on Kudu C++ client API
http://gerrit.cloudera.org:8080/#/c/19690/5//COMMIT_MSG@10
PS5, Line 10: non-unique
a non-unique
http://gerrit.cloudera.org:8080/#/c/19690/5//COMMIT_MSG@12
PS5, Line 12: STDOUT of the example:
nit: update the snippet after addressing review feedback on the example's code
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/CMakeLists.txt
File examples/cpp/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/CMakeLists.txt@21
PS5, Line 21: set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
Should this stay or this was used only during troubleshooting/debugging phase?
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@67
PS1, Line 67: KuduSchemaBuilder b;
: // Columns which are not uniquely identifiable can still be used as primary keys, by
: // specifying them as non-unique primary key.
: b.AddColumn("non_unique_key")->Type(KuduColumnSchema::INT32)->NotNull()->NonUniquePrimaryKey();
: b.AddColumn("int_val")->Type(KuduColumnSchema::INT32)->NotNull();
On a separate note: I wish we had something like AutoIncrementingColumnSchemaBuilder in C++ client. Do you think it's worth adding something like we have in Java client in C++ client as well?
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@79
PS1, Line 79: vector<string> column_names;
: // Use the non-unique key column for hash
nit: could use initializers list for 'column_names' instead of push_back?
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@377
PS1, Line 377:
the
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
PS5:
Even if Kudu C++ client API is compatible with C++98, I think that new examples should use contemporary C++ standards, where std::unique_ptr and other niceties are available to avoid memory leaks and promote bug-free code.
What do you think?
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@68
PS5, Line 68: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@81
PS5, Line 81: specifid
specified
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@111
PS5, Line 111: Status s = session->Flush();
: KUDU_RETURN_NOT_OK(s);
KUDU_RETURN_NOT_OK(session->Flush())
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@138
PS5, Line 138: // With updates in general, one has to scan the table, to get the auto-incrementing value.
: // As for update the entire set of key columns are necessary.
How about:
It's necessary to specify the entire set of key columns when updating a particular row. An auto-incrementing column is auto-populated at the server side, and one way to retrieve its values is scanning the table with a projection that includes the auto-incrementing column.
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@145
PS5, Line 145: KuduScanBatch batch;
nit: move this inside the 'while' cycle?
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@172
PS5, Line 172: Status s = session->Flush();
: KUDU_RETURN_NOT_OK(s);
nit: could be shorten to KUDU_RETURN_NOT_OK(session->Flush()) ?
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@179
PS5, Line 179: // With deletes in general, one has to scan the table, to get the auto-incrementing value.
: // As for delete the entire set of key columns are necessary.
How about:
It's necessary to specify the entire set of key columns when updating a particular row. An auto-incrementing column is auto-populated at the server side, and one way to retrieve its values is scanning the table with a projection that includes the auto-incrementing column.
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@211
PS5, Line 211: Status s = session->Flush();
: KUDU_RETURN_NOT_OK(s);
nit: KUDU_RETURN_NOT_OK(Flush())
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@219
PS5, Line 219: FATAL
ERROR
Otherwise, it would just crash for no reason with FATAL?
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@247
PS5, Line 247: a
the
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@253
PS5, Line 253: from table,
nit: drop this part
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@277
PS5, Line 277: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@278
PS5, Line 278: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@292
PS5, Line 292: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@293
PS5, Line 293: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@312
PS5, Line 312: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@314
PS5, Line 314: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@332
PS5, Line 332: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@346
PS5, Line 346: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@364
PS5, Line 364: ,
nit: drop the comma
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@371
PS5, Line 371: a
the
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Apr 2023 16:48:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
KUDU-1945 Add C++ example for non-unique PK
This patch adds an example based on Kudu C++ client API to showcase the
main operations performed on a table having a non-unique primary key.
STDOUT of the example:
Created a client connection
Created the schema:
(
non_unique_key INT32 NOT NULL,
auto_incrementing_id INT64 NOT NULL,
int_val INT32 NOT NULL,
PRIMARY KEY (non_unique_key, auto_incrementing_id)
)
Created the table
Inserted some row(s) into the table:
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Demonstrating scanning ...
Scanned some row(s) WHERE non_unique_key = 1:
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
Demonstrating UPDATE ...
Updated row(s) WHERE non_unique_key = 1 AND int_val = 2 to int_val = 98
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Updated row(s) WHERE non_unique_key = 2 to int_val = 99
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Updated row(s) WHERE non_unique_key = 2 AND auto_incrementing_id = 5 to\
int_val = 100
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=\
100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Demonstrating DELETE ...
Deleted row(s) WHERE non_unique_key = 3 AND int_val = 1
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=\
100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Deleted row(s) WHERE non_unique_key = 2
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted row(s) WHERE non_unique_key = 3 AND auto_incrementing_id = 3
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted the table
Done
Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Reviewed-on: http://gerrit.cloudera.org:8080/19690
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M examples/cpp/CMakeLists.txt
A examples/cpp/non_unique_primary_key.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client_examples-test.sh
4 files changed, 381 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 8
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@102
PS1, Line 102: incrementin
nit: incrementing
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@128
PS1, Line 128: default
Remind me if I am wrong but we currently have the default implementation only where the client never hides the auto incrementing column when returning the results of a scan?
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@182
PS1, Line 182: delte
nit here and above: delete
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 03:19:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 7
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 4:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@116
PS3, Line 116: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@137
PS3, Line 137: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@178
PS3, Line 178: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@255
PS3, Line 255: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@268
PS3, Line 268: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@275
PS3, Line 275: Update row(s
> nit: the predicate is built on non unique primary key and non PK column, mu
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@286
PS3, Line 286: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@290
PS3, Line 290: Update row(s)
> nit: the predicate is built on non unique primary key, multiple rows could
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@302
PS3, Line 302: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@323
PS3, Line 323: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@330
PS3, Line 330: Delete row(s)
> nit: the predicate is built on non unique primary key and non PK column, mu
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@340
PS3, Line 340: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@344
PS3, Line 344: Delete row(s)
> nit: Delete rows
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@354
PS3, Line 354: *
> nit: remove space
Done
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@362
PS3, Line 362: row
> nit: a
Done
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Apr 2023 16:21:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Apr 2023 21:11:07 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19690
to look at the new patch set (#3).
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
KUDU-1945 Add C++ example for non-unique PK
This patch adds an example C++ file to showcase the main operations
performed on a table having non-unique primary key.
STDOUT of the example:
Created a client connection
Created the schema:
(
non_unique_key INT32 NOT NULL,
auto_incrementing_id INT64 NOT NULL,
int_val INT32 NOT NULL,
PRIMARY KEY (non_unique_key, auto_incrementing_id)
)
Created the table
Inserted some row(s) into a table:
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Demonstrating scanning ...
Scanned some row(s) from table, WHERE non_unique_key = 1:
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
Demonstrating UPDATE ...
Updated row(s), WHERE non_unique_key = 1 AND int_val = 2,\
to int_val = 98
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Updated row(s), WHERE non_unique_key = 2, to int_val = 99
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Updated row(s), WHERE non_unique_key = 2 AND auto_incrementing_id = 5,\
to int_val = 100
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Demonstrating DELETE ...
Deleted row(s), WHERE non_unique_key = 3 AND int_val = 1
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Deleted row(s), WHERE non_unique_key = 2
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted row(s), WHERE non_unique_key = 3 AND auto_incrementing_id = 3
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted a table
Done
Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
---
M examples/cpp/CMakeLists.txt
A examples/cpp/non_unique_primary_key.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client_examples-test.sh
4 files changed, 380 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/19690/3
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19690
to look at the new patch set (#5).
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
KUDU-1945 Add C++ example for non-unique PK
This patch adds an example C++ file to showcase the main operations
performed on a table having non-unique primary key.
STDOUT of the example:
Created a client connection
Created the schema:
(
non_unique_key INT32 NOT NULL,
auto_incrementing_id INT64 NOT NULL,
int_val INT32 NOT NULL,
PRIMARY KEY (non_unique_key, auto_incrementing_id)
)
Created the table
Inserted some row(s) into a table:
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Demonstrating scanning ...
Scanned some row(s) from table, WHERE non_unique_key = 1:
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
Demonstrating UPDATE ...
Updated row(s), WHERE non_unique_key = 1 AND int_val = 2,\
to int_val = 98
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Updated row(s), WHERE non_unique_key = 2, to int_val = 99
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Updated row(s), WHERE non_unique_key = 2 AND auto_incrementing_id = 5,\
to int_val = 100
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Demonstrating DELETE ...
Deleted row(s), WHERE non_unique_key = 3 AND int_val = 1
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Deleted row(s), WHERE non_unique_key = 2
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted row(s), WHERE non_unique_key = 3 AND auto_incrementing_id = 3
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted a table
Done
Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
---
M examples/cpp/CMakeLists.txt
A examples/cpp/non_unique_primary_key.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client_examples-test.sh
4 files changed, 380 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/19690/5
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Apr 2023 18:21:53 +0000
Gerrit-HasComments: No
[kudu-CR] UDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka, Wenzhe Zhou,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19690
to look at the new patch set (#2).
Change subject: UDU-1945 Add C++ example for non-unique PK
......................................................................
UDU-1945 Add C++ example for non-unique PK
This patch adds an example C++ file to showcase the main operations
performed on a table having non-unique primary key.
STDOUT of the example:
Created a client connection
Created the schema:
(
non_unique_key INT32 NOT NULL,
auto_incrementing_id INT64 NOT NULL,
int_val INT32 NOT NULL,
PRIMARY KEY (non_unique_key, auto_incrementing_id)
)
Created the table
Inserted some row(s) into a table:
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Demonstrating scanning ...
Scanned some row(s) from table, WHERE non_unique_key = 1:
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=2)
Demonstrating UPDATE ...
Updated row(s), WHERE non_unique_key = 1 AND int_val = 2,\
to int_val = 98
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=1)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=2)
Updated row(s), WHERE non_unique_key = 2, to int_val = 99
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Updated row(s), WHERE non_unique_key = 2 AND auto_incrementing_id = 5,\
to int_val = 100
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Demonstrating DELETE ...
Deleted row(s), WHERE non_unique_key = 3 AND int_val = 1
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
(int32 non_unique_key=2, int64 auto_incrementing_id=4, int32 int_val=99)
(int32 non_unique_key=2, int64 auto_incrementing_id=5, int32\
int_val=100)
(int32 non_unique_key=2, int64 auto_incrementing_id=6, int32 int_val=99)
Deleted row(s), WHERE non_unique_key = 2
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=3, int64 auto_incrementing_id=3, int32 int_val=2)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted row(s), WHERE non_unique_key = 3 AND auto_incrementing_id = 3
(int32 non_unique_key=3, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=4, int64 auto_incrementing_id=4, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=1, int32 int_val=0)
(int32 non_unique_key=1, int64 auto_incrementing_id=2, int32 int_val=1)
(int32 non_unique_key=1, int64 auto_incrementing_id=3, int32 int_val=98)
Deleted a table
Done
Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
---
M examples/cpp/CMakeLists.txt
A examples/cpp/non_unique_primary_key.cc
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client_examples-test.sh
4 files changed, 380 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/19690/2
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 16:39:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@219
PS5, Line 219: ERROR
> Ah, I meant
Sorry about that, thanks for the clarification!
Done.
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 7
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 13:47:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
PS5:
> Absolutely! I just wasn't sure on the positioning between supporting C++98
Yep, that works. Thank you!
http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@219
PS5, Line 219: FATAL
> To run any of the C++ client apps, one has to provide the host address.
Ah, I meant
if (argc < 2) {
KUDU_LOG(ERROR) << ...;
return -1;
}
Does it make more sense to you now?
I was just thinking that calling abort() is a bit strange when it's possible to exit gracefully with non-zero exit code to indicate an error.
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 05:14:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] UDU-1945 Add C++ example for non-unique PK
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: UDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 2:
(28 comments)
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/getting_started.cc
File examples/cpp/getting_started.cc:
PS1:
> Once this file changed, you need to update README.adoc in the corresponding
I just wanted to rename this file, to indicate the the example.cc is the general getting started, and others (like this non_unique_primary_key.cc) would be feature specific.
I will keep the original example.cc filename, to avoid unnecessary headaches for now, and later I can do the renaming, if you find it also reasonable.
Thanks for mentioning this issue!
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@80
PS1, Line 80: ey column for ha
> Could we get column name from input schema?
Actually this is a good point, as I can also add explanation about the ordering of the key cols: to mention that auto-incrementing column is always the last, so we can use schema.Column(0).
Thanks for pointing this out!
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@98
PS1, Line 98: st
> indent in two spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@102
PS1, Line 102:
> nit: incrementing
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@109
PS1, Line 109: }
:
: S
> remove these three lines
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@118
PS1, Line 118: for (int i = 0; i < predicates.size(); i++) {
> add space after 'for', add a space before {
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@128
PS1, Line 128: one do
> Remind me if I am wrong but we currently have the default implementation on
You are correct. I just wanted to highlight that this is the default behaviour, and if someone wants to change this, they can introduce a projection. Changed to commend to reflect this.
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@140
PS1, Line 140: KuduScanner scanner(table.get());
> add space after 'for', add a space before {
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@158
PS1, Line 158: KU
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@165
PS1, Line 165: KU
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@172
PS1, Line 172: Status s = session->Flush();
: KUDU_RETURN_NOT_OK(s);
: r
> remove
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@182
PS1, Line 182: = 0;
> nit here and above: delete
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@184
PS1, Line 184: }
> add space after 'for', add a space before {
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@201
PS1, Line 201:
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@208
PS1, Line 208:
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@214
PS1, Line 214: }
:
:
> remove
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@257
PS1, Line 257: ", Kud
> why up case?
I just wanted to highlight, that it is used in predicate.
But it is not really necessary, changed all of these to lower case.
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@259
PS1, Line 259: KU
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@275
PS1, Line 275: //
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@278
PS1, Line 278:
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@283
PS1, Line 283:
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@290
PS1, Line 290: // Update a row.
> warning: unused variable 'int_val_EQUALS' [clang-diagnostic-unused-variable
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@299
PS1, Line 299: in
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@319
PS1, Line 319: D
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@331
PS1, Line 331: KU
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@334
PS1, Line 334: KU
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@339
PS1, Line 339: in
> nit: indent in 4 spaces
Done
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@371
PS1, Line 371: DU
> nit: indent in 4 spaces
Done
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 10:48:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 1:
(23 comments)
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@80
PS1, Line 80: "non_unique_key"
Could we get column name from input schema?
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@98
PS1, Line 98:
indent in two spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@109
PS1, Line 109: if (s.ok()) {
: return s;
: }
remove these three lines
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@118
PS1, Line 118: for(int i = 0; i < predicates.size(); i++){
add space after 'for', add a space before {
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@140
PS1, Line 140: for(int i = 0; i < predicates.size(); i++){
add space after 'for', add a space before {
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@158
PS1, Line 158:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@165
PS1, Line 165:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@172
PS1, Line 172: if (s.ok()) {
: return s;
: }
remove
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@184
PS1, Line 184: for(int i = 0; i < predicates.size(); i++){
add space after 'for', add a space before {
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@201
PS1, Line 201:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@208
PS1, Line 208:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@214
PS1, Line 214: if (s.ok()) {
: return s;
: }
remove
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@257
PS1, Line 257: EQUALS
why up case?
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@259
PS1, Line 259:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@275
PS1, Line 275:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@278
PS1, Line 278:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@283
PS1, Line 283:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@299
PS1, Line 299:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@319
PS1, Line 319:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@331
PS1, Line 331:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@334
PS1, Line 334:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@339
PS1, Line 339:
nit: indent in 4 spaces
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/non_unique_primary_key.cc@371
PS1, Line 371:
nit: indent in 4 spaces
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 03:11:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 3:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc
File examples/cpp/non_unique_primary_key.cc:
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@116
PS3, Line 116:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@137
PS3, Line 137:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@178
PS3, Line 178:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@255
PS3, Line 255:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@268
PS3, Line 268:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@275
PS3, Line 275: Update a row
nit: the predicate is built on non unique primary key and non PK column, multiple rows could be updated. Change to "Update rows".
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@286
PS3, Line 286:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@290
PS3, Line 290: Update a row.
nit: the predicate is built on non unique primary key, multiple rows could be updated. Change to "Update rows".
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@302
PS3, Line 302:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@323
PS3, Line 323:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@330
PS3, Line 330: Update a row.
nit: the predicate is built on non unique primary key and non PK column, multiple rows could be deleted. Change to "Delete rows".
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@340
PS3, Line 340:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@344
PS3, Line 344: Delete the row
nit: Delete rows
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@354
PS3, Line 354:
nit: remove space
http://gerrit.cloudera.org:8080/#/c/19690/3/examples/cpp/non_unique_primary_key.cc@362
PS3, Line 362: the
nit: a
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 05 Apr 2023 21:54:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1945 Add C++ example for non-unique PK
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19690/1/examples/cpp/getting_started.cc
File examples/cpp/getting_started.cc:
PS1:
Once this file changed, you need to update README.adoc in the corresponding directory.
I also think this file was somehow packaged into the downstream RPM package, and if you are renaming this, you need to update that stuff as well.
Anyways, if you want to rename this file, I'd suggest doing so separately from other non-related updates.
--
To view, visit http://gerrit.cloudera.org:8080/19690
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec
Gerrit-Change-Number: 19690
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Apr 2023 20:26:33 +0000
Gerrit-HasComments: Yes