You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/01/04 08:57:44 UTC
[GitHub] [submarine] liuxunorg opened a new pull request #142:
SUBMARINE-332. Fix submarine server database connection failure
liuxunorg opened a new pull request #142: SUBMARINE-332. Fix submarine server database connection failure
URL: https://github.com/apache/submarine/pull/142
### What is this PR for?
The submarine server cannot access the database due to the following issues
1. Mysql configuration file is missing parameters in `submairne-site.xml`.
2. In the pom file submarine project, without introducing mysql connector jar package
### What type of PR is it?
[Bug Fix | Improvement ]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/SUBMARINE-332
### How should this be tested?
* [CI Pass](https://travis-ci.org/liuxunorg/submarine/builds/632581397)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #142:
SUBMARINE-332. Fix submarine server database connection failure
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #142: SUBMARINE-332. Fix submarine server database connection failure
URL: https://github.com/apache/submarine/pull/142#discussion_r363026138
##########
File path: bin/common.sh
##########
@@ -73,8 +73,18 @@ function download_mysql_jdbc_jar(){
fi
MYSQL_JAR_URL="https://repo1.maven.org/maven2/mysql/mysql-connector-java/${MYSQL_VERSION}/mysql-connector-java-${MYSQL_VERSION}.jar"
fi
+
echo "Downloading mysql jdbc jar from ${MYSQL_JAR_URL}."
- wget ${MYSQL_JAR_URL} -P "${BIN}/../lib"
+ if type wget >/dev/null 2>&1; then
+ wget ${MYSQL_JAR_URL} -P "${BIN}/../lib" --no-check-certificate
+ elif type curl >/dev/null 2>&1; then
+ curl -o "${BIN}/../lib/mysql-connector-java-${MYSQL_VERSION}.jar" ${MYSQL_JAR_URL}
Review comment:
This is a good question.
But using the `SUBMARINE_HOME` variable, you must define the path in `submarine-env.sh`.
I think it may be easier to use `SUBMARINE_HOME` in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #142: SUBMARINE-332. Fix
submarine server database connection failure
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #142: SUBMARINE-332. Fix submarine server database connection failure
URL: https://github.com/apache/submarine/pull/142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #142:
SUBMARINE-332. Fix submarine server database connection failure
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on a change in pull request #142: SUBMARINE-332. Fix submarine server database connection failure
URL: https://github.com/apache/submarine/pull/142#discussion_r363028339
##########
File path: bin/common.sh
##########
@@ -73,8 +73,18 @@ function download_mysql_jdbc_jar(){
fi
MYSQL_JAR_URL="https://repo1.maven.org/maven2/mysql/mysql-connector-java/${MYSQL_VERSION}/mysql-connector-java-${MYSQL_VERSION}.jar"
fi
+
echo "Downloading mysql jdbc jar from ${MYSQL_JAR_URL}."
- wget ${MYSQL_JAR_URL} -P "${BIN}/../lib"
+ if type wget >/dev/null 2>&1; then
+ wget ${MYSQL_JAR_URL} -P "${BIN}/../lib" --no-check-certificate
+ elif type curl >/dev/null 2>&1; then
+ curl -o "${BIN}/../lib/mysql-connector-java-${MYSQL_VERSION}.jar" ${MYSQL_JAR_URL}
Review comment:
Okay, thanks for your reminder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #142:
SUBMARINE-332. Fix submarine server database connection failure
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #142: SUBMARINE-332. Fix submarine server database connection failure
URL: https://github.com/apache/submarine/pull/142#discussion_r363025603
##########
File path: bin/common.sh
##########
@@ -73,8 +73,18 @@ function download_mysql_jdbc_jar(){
fi
MYSQL_JAR_URL="https://repo1.maven.org/maven2/mysql/mysql-connector-java/${MYSQL_VERSION}/mysql-connector-java-${MYSQL_VERSION}.jar"
fi
+
echo "Downloading mysql jdbc jar from ${MYSQL_JAR_URL}."
- wget ${MYSQL_JAR_URL} -P "${BIN}/../lib"
+ if type wget >/dev/null 2>&1; then
+ wget ${MYSQL_JAR_URL} -P "${BIN}/../lib" --no-check-certificate
+ elif type curl >/dev/null 2>&1; then
+ curl -o "${BIN}/../lib/mysql-connector-java-${MYSQL_VERSION}.jar" ${MYSQL_JAR_URL}
Review comment:
Could we use "${SUBMARINE_HOME}/lib/mysql-connector-java-${MYSQL_VERSION}.jar"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] pingsutw commented on issue #142: SUBMARINE-332. Fix
submarine server database connection failure
Posted by GitBox <gi...@apache.org>.
pingsutw commented on issue #142: SUBMARINE-332. Fix submarine server database connection failure
URL: https://github.com/apache/submarine/pull/142#issuecomment-570776927
Thanks @liuxunorg for the contribution, LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #142: SUBMARINE-332. Fix
submarine server database connection failure
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #142: SUBMARINE-332. Fix submarine server database connection failure
URL: https://github.com/apache/submarine/pull/142#issuecomment-570777056
@pingsutw Thank you help me review code.
Will merge if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #142:
SUBMARINE-332. Fix submarine server database connection failure
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #142: SUBMARINE-332. Fix submarine server database connection failure
URL: https://github.com/apache/submarine/pull/142#discussion_r363026662
##########
File path: bin/common.sh
##########
@@ -73,8 +73,18 @@ function download_mysql_jdbc_jar(){
fi
MYSQL_JAR_URL="https://repo1.maven.org/maven2/mysql/mysql-connector-java/${MYSQL_VERSION}/mysql-connector-java-${MYSQL_VERSION}.jar"
fi
+
echo "Downloading mysql jdbc jar from ${MYSQL_JAR_URL}."
- wget ${MYSQL_JAR_URL} -P "${BIN}/../lib"
+ if type wget >/dev/null 2>&1; then
+ wget ${MYSQL_JAR_URL} -P "${BIN}/../lib" --no-check-certificate
+ elif type curl >/dev/null 2>&1; then
+ curl -o "${BIN}/../lib/mysql-connector-java-${MYSQL_VERSION}.jar" ${MYSQL_JAR_URL}
Review comment:
`SUBMARINE_HOME ` already define in common.sh
https://github.com/apache/submarine/blob/7576a5e300b4659c3a8a36c035e125d7a5c7f44e/bin/common.sh#L30
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org