You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/22 09:17:09 UTC

[GitHub] [apisix-go-plugin-runner] spacewander commented on a diff in pull request #93: docs: add response filter for doc

spacewander commented on code in PR #93:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/93#discussion_r903494941


##########
docs/en/latest/getting-started.md:
##########
@@ -159,8 +194,9 @@ When you configure a plugin runner in APISIX, APISIX will treat the plugin runne
 
 If you configure the ext-plugin-* plugin for a given route, a request to hit that route will trigger APISIX to make an RPC call to the plugin runner via a unix socket. The call is broken down into two phases.
 
-- ext-plugin-pre-req: before executing most of the APISIX built-in plugins (Lua language plugins)
-- ext-plugin-post-req: after the execution of the APISIX built-in plugins (Lua language plugins)
+- ext-plugin-pre-req: executed in the request phase, before most of the APISIX built-in plugins (Lua language plugins)

Review Comment:
   There is no phase called `request phase`, what about using `during handling the request`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org