You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/12/06 00:15:44 UTC

[jira] Created: (HADOOP-4794) separate branch for HadoopVersionAnnotation

separate branch for HadoopVersionAnnotation
-------------------------------------------

                 Key: HADOOP-4794
                 URL: https://issues.apache.org/jira/browse/HADOOP-4794
             Project: Hadoop Core
          Issue Type: Improvement
          Components: build
            Reporter: Owen O'Malley


I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4794) separate branch for HadoopVersionAnnotation

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4794:
----------------------------------

    Attachment: 4794-0.patch

Patch to saveVersion and jsps, adding the branch to the version annotation.

A note on the implementation: for subversion, this takes the repository root and appends a prefix ("hadoop/core" by default) to build the url. The branch is whatever remains after the root + prefix (e.g. "branches/branch-0.19"). This permits non-canonical names for branches (e.g. "experimental/branchA" in addition to "branches/foo", "tags/bar", and "trunk"). Since most users observe the convention, supporting this use case may not be necessary.

> separate branch for HadoopVersionAnnotation
> -------------------------------------------
>
>                 Key: HADOOP-4794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4794
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: 4794-0.patch
>
>
> I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4794) separate branch for HadoopVersionAnnotation

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657782#action_12657782 ] 

Hadoop QA commented on HADOOP-4794:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12396151/4794-1.patch
  against trunk revision 727660.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3753/console

This message is automatically generated.

> separate branch for HadoopVersionAnnotation
> -------------------------------------------
>
>                 Key: HADOOP-4794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4794
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Chris Douglas
>         Attachments: 4794-0.patch, 4794-1.patch
>
>
> I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4794) separate branch for HadoopVersionAnnotation

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-4794:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.21.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Chris!

> separate branch for HadoopVersionAnnotation
> -------------------------------------------
>
>                 Key: HADOOP-4794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4794
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Chris Douglas
>             Fix For: 0.21.0
>
>         Attachments: 4794-0.patch, 4794-1.patch
>
>
> I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4794) separate branch for HadoopVersionAnnotation

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4794:
----------------------------------

    Assignee: Chris Douglas  (was: Owen O'Malley)
      Status: Patch Available  (was: Open)

> separate branch for HadoopVersionAnnotation
> -------------------------------------------
>
>                 Key: HADOOP-4794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4794
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Chris Douglas
>         Attachments: 4794-0.patch, 4794-1.patch
>
>
> I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-4794) separate branch for HadoopVersionAnnotation

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley reassigned HADOOP-4794:
-------------------------------------

    Assignee: Owen O'Malley

> separate branch for HadoopVersionAnnotation
> -------------------------------------------
>
>                 Key: HADOOP-4794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4794
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>
> I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-4794) separate branch for HadoopVersionAnnotation

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-4794:
----------------------------------

    Attachment: 4794-1.patch

Alternative matching branches/\*, tags/\* or trunk.

> separate branch for HadoopVersionAnnotation
> -------------------------------------------
>
>                 Key: HADOOP-4794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4794
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>         Attachments: 4794-0.patch, 4794-1.patch
>
>
> I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-4794) separate branch for HadoopVersionAnnotation

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653973#action_12653973 ] 

Owen O'Malley commented on HADOOP-4794:
---------------------------------------

For subversion, it would look like:

url = "http://svn.apache.org/repos/asf/hadoop/core"
branch = "branches/branch-0.18"

For git, it would look like:

url = "git://localhost/home/oom/hadoop-git"
branch = "h1234"

> separate branch for HadoopVersionAnnotation
> -------------------------------------------
>
>                 Key: HADOOP-4794
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4794
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: build
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>
> I think we should pull out the "branch" in the HadoopVersionAnnotation and display it on the Web/UI.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.