You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/10 21:46:15 UTC
Review Request 39207: Windows: Move `write` to its own file,
`stout/os/write.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39207/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3632
https://issues.apache.org/jira/browse/MESOS-3632
Repository: mesos
Description
-------
Windows: Move `write` to its own file, `stout/os/write.hpp`.
(This part isn't going in the commit message, but just FYI, we're doing this (1) because we need it to support `slave/state.hpp`, (2) because we don't want to port all of `os.hpp` to get this one function, and (3) because `stout/os/read.hpp` already exists, so it makes sense to have one for `write` as well.)
(Also, please do not close MESOS-3632, this is just a partial solution.)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda
Diff: https://reviews.apache.org/r/39207/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39207: Windows: Move `write` to its own file,
`stout/os/write.hpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39207/#review102323
-----------------------------------------------------------
Ship it!
LGTM. Verified that none of the `write` logic changed in the move.
- Joseph Wu
On Oct. 10, 2015, 12:47 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39207/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2015, 12:47 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Move `write` to its own file, `stout/os/write.hpp`.
>
> (This part isn't going in the commit message, but just FYI, we're doing this (1) because we need it to support `slave/state.hpp`, (2) because we don't want to port all of `os.hpp` to get this one function, and (3) because `stout/os/read.hpp` already exists, so it makes sense to have one for `write` as well.)
>
> (Also, please do not close MESOS-3632, this is just a partial solution.)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda
>
> Diff: https://reviews.apache.org/r/39207/diff/
>
>
> Testing
> -------
>
> Ran `make check` on Windows 10, OS X 10.10, Ubuntu 15. On Ubuntu 15, we also checked that the autotools solution builds and the tests run as well.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39207: Windows: Move `write` to its own file,
`stout/os/write.hpp`.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39207/#review102177
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39019, 39076, 39091, 39092, 39093, 39096, 39097, 39180, 39181, 39201, 39182, 39202, 39203, 39204, 39207]
All tests passed.
- Mesos ReviewBot
On Oct. 10, 2015, 7:47 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39207/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2015, 7:47 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Move `write` to its own file, `stout/os/write.hpp`.
>
> (This part isn't going in the commit message, but just FYI, we're doing this (1) because we need it to support `slave/state.hpp`, (2) because we don't want to port all of `os.hpp` to get this one function, and (3) because `stout/os/read.hpp` already exists, so it makes sense to have one for `write` as well.)
>
> (Also, please do not close MESOS-3632, this is just a partial solution.)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda
>
> Diff: https://reviews.apache.org/r/39207/diff/
>
>
> Testing
> -------
>
> Ran `make check` on Windows 10, OS X 10.10, Ubuntu 15. On Ubuntu 15, we also checked that the autotools solution builds and the tests run as well.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39207: Windows: Move `write` to its own file,
`stout/os/write.hpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39207/#review103036
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp (lines 88 - 91)
<https://reviews.apache.org/r/39207/#comment160876>
I think in other places we alphabetize these even with conditional compilation blocks right?
3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp (lines 20 - 21)
<https://reviews.apache.org/r/39207/#comment160877>
let's split out the sub-directory.
- Joris Van Remoortere
On Oct. 13, 2015, 6:30 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39207/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 6:30 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3632
> https://issues.apache.org/jira/browse/MESOS-3632
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Move `write` to its own file, `stout/os/write.hpp`.
>
> (This part isn't going in the commit message, but just FYI, we're doing this (1) because we need it to support `slave/state.hpp`, (2) because we don't want to port all of `os.hpp` to get this one function, and (3) because `stout/os/read.hpp` already exists, so it makes sense to have one for `write` as well.)
>
> (Also, please do not close MESOS-3632, this is just a partial solution.)
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp a042d061159c83e1652e7288b90809981d2818c9
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda
>
> Diff: https://reviews.apache.org/r/39207/diff/
>
>
> Testing
> -------
>
> Ran `make check` on Windows 10, OS X 10.10, Ubuntu 15. On Ubuntu 15, we also checked that the autotools solution builds and the tests run as well.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39207: Windows: Move `write` to its own file,
`stout/os/write.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39207/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 6:30 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3632
https://issues.apache.org/jira/browse/MESOS-3632
Repository: mesos
Description
-------
Windows: Move `write` to its own file, `stout/os/write.hpp`.
(This part isn't going in the commit message, but just FYI, we're doing this (1) because we need it to support `slave/state.hpp`, (2) because we don't want to port all of `os.hpp` to get this one function, and (3) because `stout/os/read.hpp` already exists, so it makes sense to have one for `write` as well.)
(Also, please do not close MESOS-3632, this is just a partial solution.)
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp a042d061159c83e1652e7288b90809981d2818c9
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda
Diff: https://reviews.apache.org/r/39207/diff/
Testing
-------
Ran `make check` on Windows 10, OS X 10.10, Ubuntu 15. On Ubuntu 15, we also checked that the autotools solution builds and the tests run as well.
Thanks,
Alex Clemmer
Re: Review Request 39207: Windows: Move `write` to its own file,
`stout/os/write.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39207/
-----------------------------------------------------------
(Updated Oct. 10, 2015, 7:47 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3632
https://issues.apache.org/jira/browse/MESOS-3632
Repository: mesos
Description
-------
Windows: Move `write` to its own file, `stout/os/write.hpp`.
(This part isn't going in the commit message, but just FYI, we're doing this (1) because we need it to support `slave/state.hpp`, (2) because we don't want to port all of `os.hpp` to get this one function, and (3) because `stout/os/read.hpp` already exists, so it makes sense to have one for `write` as well.)
(Also, please do not close MESOS-3632, this is just a partial solution.)
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5
3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda
Diff: https://reviews.apache.org/r/39207/diff/
Testing (updated)
-------
Ran `make check` on Windows 10, OS X 10.10, Ubuntu 15. On Ubuntu 15, we also checked that the autotools solution builds and the tests run as well.
Thanks,
Alex Clemmer