You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@clerezza.apache.org by "Manuel Innerhofer (JIRA)" <ji...@apache.org> on 2010/03/15 17:22:27 UTC
[jira] Created: (CLEREZZA-163) in
org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel
should not set a -tag)
in org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel should not set a <!DOCTYPE... if HTML not complete (e.g. no <html>-tag)
--------------------------------------------------------------------------------------------------------------------------------------------------
Key: CLEREZZA-163
URL: https://issues.apache.org/jira/browse/CLEREZZA-163
Project: Clerezza
Issue Type: Improvement
Reporter: Manuel Innerhofer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-163) in
org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel
should not set a -tag)
Posted by "Manuel Innerhofer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846819#action_12846819 ]
Manuel Innerhofer commented on CLEREZZA-163:
--------------------------------------------
Did not add test, I'll add it on the refactoring occasion.
> in org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel should not set a <!DOCTYPE... if HTML not complete (e.g. no <html>-tag)
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLEREZZA-163
> URL: https://issues.apache.org/jira/browse/CLEREZZA-163
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Manuel Innerhofer
> Assignee: Manuel Innerhofer
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CLEREZZA-163) in
org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel
should not set a -tag)
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür reopened CLEREZZA-163:
-----------------------------------------
Assignee: Manuel Innerhofer
please fix the obvious now and do a refactoring on occasion. A missing test is on ethat shows that xhtml snippets are in fact converted to html snippets, you only test that no doctype is added.
> in org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel should not set a <!DOCTYPE... if HTML not complete (e.g. no <html>-tag)
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLEREZZA-163
> URL: https://issues.apache.org/jira/browse/CLEREZZA-163
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Manuel Innerhofer
> Assignee: Manuel Innerhofer
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CLEREZZA-163) in
org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel
should not set a -tag)
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846328#action_12846328 ]
Reto Bachmann-Gmür commented on CLEREZZA-163:
---------------------------------------------
both in test and actual code it's convention to start method names with lower case characters (just what occurs to me having a hard time understand the overall code)
NEXTLINE = "\n".getBytes()[0]; is a bit awkward for NEXTLINE = '\n';
RemoveXmlDeclarationAndDotnotAddDoctypeIfHtmlNotComplete, apart from the casing there's a typo
I think the code could be more readable but given that the tests seem rather complete, I'd say its acceptable now.
> in org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel should not set a <!DOCTYPE... if HTML not complete (e.g. no <html>-tag)
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLEREZZA-163
> URL: https://issues.apache.org/jira/browse/CLEREZZA-163
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Manuel Innerhofer
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (CLEREZZA-163) in
org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel
should not set a -tag)
Posted by "Manuel Innerhofer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manuel Innerhofer closed CLEREZZA-163.
--------------------------------------
> in org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel should not set a <!DOCTYPE... if HTML not complete (e.g. no <html>-tag)
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLEREZZA-163
> URL: https://issues.apache.org/jira/browse/CLEREZZA-163
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Manuel Innerhofer
> Assignee: Manuel Innerhofer
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLEREZZA-163) in
org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel
should not set a -tag)
Posted by "Manuel Innerhofer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manuel Innerhofer resolved CLEREZZA-163.
----------------------------------------
Resolution: Fixed
> in org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel should not set a <!DOCTYPE... if HTML not complete (e.g. no <html>-tag)
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLEREZZA-163
> URL: https://issues.apache.org/jira/browse/CLEREZZA-163
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Manuel Innerhofer
> Assignee: Manuel Innerhofer
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CLEREZZA-163) in
org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel
should not set a -tag)
Posted by "Manuel Innerhofer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CLEREZZA-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Manuel Innerhofer resolved CLEREZZA-163.
----------------------------------------
Resolution: Fixed
> in org.apache.clerezza.platform.xhtml2html the DocTypeFilteringByteChannel should not set a <!DOCTYPE... if HTML not complete (e.g. no <html>-tag)
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CLEREZZA-163
> URL: https://issues.apache.org/jira/browse/CLEREZZA-163
> Project: Clerezza
> Issue Type: Improvement
> Reporter: Manuel Innerhofer
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.