You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2025/01/16 10:03:48 UTC
[PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
eladkal opened a new pull request, #45705:
URL: https://github.com/apache/airflow/pull/45705
This PR is against **v2-10-test**
I'd like to make sure we deliver deprecation notice as early as possible.
Users should migrate to SmtpNotifier. Email is just another notification integration it should not be favoured by Airflow core.
We have a very nice template introduced in https://github.com/apache/airflow/pull/36226 so migration should be simple enough.
Removal of email integration from main branch will be handled as part of https://github.com/apache/airflow/pull/30531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #45705:
URL: https://github.com/apache/airflow/pull/45705#issuecomment-2603837850
> Not specific to this PR, are patches to v2-10-test at this point going into a 2.10 patch release, or 2.11.0?
Depends on what if we decide to do 2.11 - I think this was not yet decided in the last dev call.
Regardless 2.11 branch will be cut from 2.10 branch so from PRs point of view it's the same process for merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on PR #45705:
URL: https://github.com/apache/airflow/pull/45705#issuecomment-2609408727
@eladkal I think we need to add `ignore::RemovedInAirflow3Warning` in [pyproject.py](https://github.com/apache/airflow/blob/f01c53a73573a5dacb2107944d32a5fd731d64f6/pyproject.toml#L468) for the tests to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #45705:
URL: https://github.com/apache/airflow/pull/45705#issuecomment-2603832863
Not specific to this PR, are patches to v2-10-test at this point going into a 2.10 patch release, or 2.11.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #45705:
URL: https://github.com/apache/airflow/pull/45705#issuecomment-2609669963
> @eladkal I think we need to add `ignore::RemovedInAirflow3Warning` in [pyproject.py](https://github.com/apache/airflow/blob/f01c53a73573a5dacb2107944d32a5fd731d64f6/pyproject.toml#L468) for the tests to pass.
We can't because of
https://github.com/apache/airflow/blob/f01c53a73573a5dacb2107944d32a5fd731d64f6/pyproject.toml#L492-L499
The issue is `RemovedInAirflow3Warning` already there yet tests are failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed pull request #45705: Deprecating email, email_on_retry, email_on_failure in `BaseOperator`
URL: https://github.com/apache/airflow/pull/45705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecating email, email_on_retry, email_on_failure in `BaseOperator` [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #45705:
URL: https://github.com/apache/airflow/pull/45705#issuecomment-2687976656
Closed in favor of https://github.com/apache/airflow/pull/47146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org