You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/21 12:59:13 UTC
[GitHub] [yunikorn-core] HuangTing-Yao opened a new pull request, #454: [YUNIKORN-1075]Upgrade Prometheus version
HuangTing-Yao opened a new pull request, #454:
URL: https://github.com/apache/yunikorn-core/pull/454
### What is this PR for?
Upgrade the `prometheus/client_golang` version to 1.12.2 in `go.mod`
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1075
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #454: [YUNIKORN-1075]Upgrade Prometheus version
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #454:
URL: https://github.com/apache/yunikorn-core/pull/454#issuecomment-1322033957
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#454](https://codecov.io/gh/apache/yunikorn-core/pull/454?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (742beeb) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/67362f156798a8e4330765cc10ff3e47970d603a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67362f1) will **increase** coverage by `0.10%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #454 +/- ##
==========================================
+ Coverage 72.54% 72.64% +0.10%
==========================================
Files 67 67
Lines 9823 9823
==========================================
+ Hits 7126 7136 +10
+ Misses 2457 2446 -11
- Partials 240 241 +1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/454/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `78.63% <0.00%> (+1.70%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s commented on pull request #454: [YUNIKORN-1075]Upgrade Prometheus version
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #454:
URL: https://github.com/apache/yunikorn-core/pull/454#issuecomment-1322928923
@HuangTing-Yao is it possible to move to [1.13.1](https://github.com/prometheus/client_golang/releases/tag/v1.13.1) instead of 0.12.2? We're making a jump can we make it as big as possible. 1.14.0 seems a bit too new to use but the 1.13 release has had some time out already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] HuangTing-Yao commented on pull request #454: [YUNIKORN-1075]Upgrade Prometheus version
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on PR #454:
URL: https://github.com/apache/yunikorn-core/pull/454#issuecomment-1323110730
> @HuangTing-Yao is it possible to move to [1.13.1](https://github.com/prometheus/client_golang/releases/tag/v1.13.1) instead of 0.12.2? We're making a jump can we make it as big as possible. 1.14.0 seems a bit too new to use but the 1.13 release has had some time out already.
@wilfred-s Sure, Let me give iti a try. I will try to upgrade prometheus client_go version to 1.13.1 to instead of 1.12.2.
Will commit soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] HuangTing-Yao commented on pull request #454: [YUNIKORN-1075]Upgrade Prometheus version
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on PR #454:
URL: https://github.com/apache/yunikorn-core/pull/454#issuecomment-1323689894
@wilfred-s Already update to 1.13.1. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #454: [YUNIKORN-1075]Upgrade Prometheus version
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #454: [YUNIKORN-1075]Upgrade Prometheus version
URL: https://github.com/apache/yunikorn-core/pull/454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org