You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Geir Magnusson Jr." <ge...@optonline.net> on 2005/09/16 14:48:33 UTC

Re: svn commit: r289302 - /geronimo/devtools/trunk/modules/eclipse-plugin/assembly/maven.xml

do you really want to call it v1.0.0?

maybe tack on a -dev or something to indicate it's not a release?


On Sep 15, 2005, at 3:54 PM, sppatel@apache.org wrote:

> Author: sppatel
> Date: Thu Sep 15 12:54:49 2005
> New Revision: 289302
>
> URL: http://svn.apache.org/viewcvs?rev=289302&view=rev
> Log:
> change binary dist zip name to geronimo-eclipse-plugin-1.0.0.zip
>
> Modified:
>     geronimo/devtools/trunk/modules/eclipse-plugin/assembly/maven.xml
>
> Modified: geronimo/devtools/trunk/modules/eclipse-plugin/assembly/ 
> maven.xml
> URL: http://svn.apache.org/viewcvs/geronimo/devtools/trunk/modules/ 
> eclipse-plugin/assembly/maven.xml? 
> rev=289302&r1=289301&r2=289302&view=diff
> ====================================================================== 
> ========
> --- geronimo/devtools/trunk/modules/eclipse-plugin/assembly/ 
> maven.xml (original)
> +++ geronimo/devtools/trunk/modules/eclipse-plugin/assembly/ 
> maven.xml Thu Sep 15 12:54:49 2005
> @@ -43,7 +43,7 @@
>
>      <goal name="zipdistribution">
>         <ant:echo>Packaging deployable feature</ant:echo>
> -       <ant:zip destfile="${maven.build.dir}/geronimo-server- 
> adapter_${pom.currentVersion}.zip" basedir="$ 
> {feature.assembly.distributions.dir}"/>
> +       <ant:zip destfile="${maven.build.dir}/geronimo-eclipse- 
> plugin-${pom.currentVersion}.zip" basedir="$ 
> {feature.assembly.distributions.dir}"/>
>      </goal>
>
>      <goal name="deploy">
>
>
>

-- 
Geir Magnusson Jr                                  +1-203-665-6437
geir@optonline.net



Re: svn commit: r289302 - /geronimo/devtools/trunk/modules/eclipse-plugin/assembly/maven.xml

Posted by Sachin Patel <sp...@gmail.com>.
Yeah, good call.  For eclipse to be able to load the plugin it needs to 
end in a version number.  I can bump the versions down.

Geir Magnusson Jr. wrote:
> do you really want to call it v1.0.0?
>
> maybe tack on a -dev or something to indicate it's not a release?
>
>
> On Sep 15, 2005, at 3:54 PM, sppatel@apache.org wrote:
>
>> Author: sppatel
>> Date: Thu Sep 15 12:54:49 2005
>> New Revision: 289302
>>
>> URL: http://svn.apache.org/viewcvs?rev=289302&view=rev
>> Log:
>> change binary dist zip name to geronimo-eclipse-plugin-1.0.0.zip
>>
>> Modified:
>>     geronimo/devtools/trunk/modules/eclipse-plugin/assembly/maven.xml
>>
>> Modified: 
>> geronimo/devtools/trunk/modules/eclipse-plugin/assembly/maven.xml
>> URL: 
>> http://svn.apache.org/viewcvs/geronimo/devtools/trunk/modules/eclipse-plugin/assembly/maven.xml?rev=289302&r1=289301&r2=289302&view=diff 
>>
>> ============================================================================== 
>>
>> --- geronimo/devtools/trunk/modules/eclipse-plugin/assembly/maven.xml 
>> (original)
>> +++ geronimo/devtools/trunk/modules/eclipse-plugin/assembly/maven.xml 
>> Thu Sep 15 12:54:49 2005
>> @@ -43,7 +43,7 @@
>>
>>      <goal name="zipdistribution">
>>         <ant:echo>Packaging deployable feature</ant:echo>
>> -       <ant:zip 
>> destfile="${maven.build.dir}/geronimo-server-adapter_${pom.currentVersion}.zip" 
>> basedir="${feature.assembly.distributions.dir}"/>
>> +       <ant:zip 
>> destfile="${maven.build.dir}/geronimo-eclipse-plugin-${pom.currentVersion}.zip" 
>> basedir="${feature.assembly.distributions.dir}"/>
>>      </goal>
>>
>>      <goal name="deploy">
>>
>>
>>
>
> --Geir Magnusson Jr                                  +1-203-665-6437
> geir@optonline.net
>
>
>