You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/27 08:39:23 UTC
[GitHub] [pulsar] lhotari opened a new pull request #11816: [Client] Set key in message metadata for batch message built with KEY_BASED batch builder
lhotari opened a new pull request #11816:
URL: https://github.com/apache/pulsar/pull/11816
### Motivation
The `BatcherBuilder.KEY_BASED` doesn't seem to work with `KEY_SHARED` consumers.
When looking at the code, it can be seen that the message metadata for the batch message doesn't contain keying metadata that KEY_SHARED consumers use for selecting messages.
### Modifications
- copy orderingKey or partitionKey&partitionKeyB64Encoded fields from the metadata of the first message that creates a new batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #11816: [Client] Set key in message metadata for batch message built with KEY_BASED batch builder
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #11816:
URL: https://github.com/apache/pulsar/pull/11816#issuecomment-907046518
@codelipenghui it looks like the required code to set orderingKey and partitionKey for the batch message got removed in PR #7416 . Was that an intentional change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #11816: [Client] Set key in message metadata for batch message built with KEY_BASED batch builder
Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #11816:
URL: https://github.com/apache/pulsar/pull/11816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #11816: [Client] Set key in message metadata for batch message built with KEY_BASED batch builder
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #11816:
URL: https://github.com/apache/pulsar/pull/11816#issuecomment-907091828
actually it seems that this PR is invalid since the logic was just moved to another location in code by #7416 . I'll close this PR as invalid. I guess there would have to be some integration tests to verify the KEY_BASED batch builder issues that I'm trying to investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #11816: [Client] Set key in message metadata for batch message built with KEY_BASED batch builder
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #11816:
URL: https://github.com/apache/pulsar/pull/11816#issuecomment-907033064
This needs tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org