[GitHub] [mynewt-core] benmccrea opened a new pull request #2151: Dialog SPI HAL should not initialize SS pin in master mode

[GitBox <gi...@apache.org>]

benmccrea opened a new pull request #2151: Dialog SPI HAL should not initialize SS pin in master mode
URL: https://github.com/apache/mynewt-core/pull/2151
 
 
   Removes initialization of the SS pin from `hal_spi_init_master` in the mcu/dialog HAL. 
   
   Explanation:
   Currently `hal_spi_init_master` initializes the SS pin, which is should only be done if the SPI is operating in slave mode. Since no syscfg exists to define the SS pin for master mode, it defaults to 0 and the following code will set port 0 pin 0 to MCU_GPIO_MODE_INPUT:
   ```
       if (cfg->pin_ss >= 0) {
           mcu_gpio_set_pin_function(cfg->pin_ss, MCU_GPIO_MODE_INPUT,
                                     spi->hw->spi_ss_func);
       }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] vrahane merged pull request #2151: Dialog SPI HAL should not initialize SS pin in master mode

[GitBox <gi...@apache.org>]

vrahane merged pull request #2151: Dialog SPI HAL should not initialize SS pin in master mode
URL: https://github.com/apache/mynewt-core/pull/2151
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services