You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by rg...@apache.org on 2007/02/02 17:59:14 UTC

svn commit: r502655 - /incubator/qpid/trunk/qpid/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java

Author: rgreig
Date: Fri Feb  2 08:59:14 2007
New Revision: 502655

URL: http://svn.apache.org/viewvc?view=rev&rev=502655
Log:
(Submitted by Rupert Smith) Options moved to top of contructor. Were at bottom and not being used!

Modified:
    incubator/qpid/trunk/qpid/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java

Modified: incubator/qpid/trunk/qpid/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java
URL: http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java?view=diff&rev=502655&r1=502654&r2=502655
==============================================================================
--- incubator/qpid/trunk/qpid/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java (original)
+++ incubator/qpid/trunk/qpid/java/perftests/src/main/java/org/apache/qpid/requestreply/PingPongProducer.java Fri Feb  2 08:59:14 2007
@@ -358,6 +358,18 @@
                       + txBatchSize + ", int noOfDestinations = " + noOfDestinations + ", int rate = " + rate
                       + ", boolean pubsub = " + pubsub + ", boolean unique = " + unique + "): called");
 
+        // Keep all the relevant options.
+        _persistent = persistent;
+        _messageSize = messageSize;
+        _verbose = verbose;
+        _failAfterCommit = afterCommit;
+        _failBeforeCommit = beforeCommit;
+        _failAfterSend = afterSend;
+        _failBeforeSend = beforeSend;
+        _failOnce = failOnce;
+        _txBatchSize = txBatchSize;
+        _isPubSub = pubsub;
+
         // Check that one or more destinations were specified.
         if (noOfDestinations < 1)
         {
@@ -388,18 +400,6 @@
         createProducer();
         createPingDestinations(noOfDestinations, selector, destinationName, unique);
         createReplyConsumers(getReplyDestinations(), selector);
-
-        // Keep all the remaining options.
-        _persistent = persistent;
-        _messageSize = messageSize;
-        _verbose = verbose;
-        _failAfterCommit = afterCommit;
-        _failBeforeCommit = beforeCommit;
-        _failAfterSend = afterSend;
-        _failBeforeSend = beforeSend;
-        _failOnce = failOnce;
-        _txBatchSize = txBatchSize;
-        _isPubSub = pubsub;
     }
 
     /**
@@ -575,21 +575,25 @@
             // Generate an id, unique within this pinger or to the whole JVM depending on the unique flag.
             if (unique)
             {
+                _logger.debug("Creating unique destinations.");
                 id = _queueJVMSequenceID.incrementAndGet();
             }
             else
             {
+                _logger.debug("Creating shared destinations.");
                 id = _queueSharedId.incrementAndGet();
             }
 
             // Check if this is a pub/sub pinger, in which case create topics.
             if (_isPubSub)
             {
+                _logger.debug("Creating topics.");
                 destination = new AMQTopic(rootName + id);
             }
             // Otherwise this is a p2p pinger, in which case create queues.
             else
             {
+                _logger.debug("Creating queues.");
                 destination = new AMQQueue(rootName + id);
             }