[GitHub] [kafka] C0urante commented on a diff in pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

[GitBox <gi...@apache.org>]

C0urante commented on code in PR #12802:
URL: https://github.com/apache/kafka/pull/12802#discussion_r1036308969


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##########
@@ -1645,6 +1646,8 @@ private void startAndStop(Collection<Callable<Void>> callables) {
             startAndStopExecutor.invokeAll(callables);
         } catch (InterruptedException e) {
             // ignore
+        } catch (RejectedExecutionException re) {
+            log.error("startAndStopExecutor already shutdown or full. Not invoking explicit connector/task shutdown");

Review Comment:
   This doesn't address the issue described in the ticket. We don't want to handle a `RejectedExecutionException` here, we want to shut down the connectors and tasks running on the herder before shutting down the `startAndStopExecutor`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org