You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "David Crossley (JIRA)" <ji...@apache.org> on 2005/08/24 04:08:08 UTC
[jira] Created: (FOR-644) whitespace cleanup
whitespace cleanup
------------------
Key: FOR-644
URL: http://issues.apache.org/jira/browse/FOR-644
Project: Forrest
Type: Task
Versions: 0.8-dev
Reporter: David Crossley
Fix For: 0.8-dev
We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and see the list at trunk/etc/whitespace-cleanup.txt
This Issue will be used to announce which section of the repository is due to be cleaned next. Please keep discussion on that mail thread.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485964 ]
David Crossley commented on FOR-644:
------------------------------------
I tried the current CVS of tidy.sf.net and it seems that that issue is still present.
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Crossley reassigned FOR-644:
----------------------------------
Assignee: (was: David Crossley)
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8-dev, 0.9
> Reporter: David Crossley
> Fix For: 0.9
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-644) code-style cleanup for xml files
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861070#action_12861070 ]
Tim Williams commented on FOR-644:
----------------------------------
It seems that this was done before the 0.8 release, is this just a house-keeping task that needs to be done prior to each release (e.g. in the same sense as license-checking)?
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8, 0.9-dev
> Reporter: David Crossley
> Fix For: 0.9-dev
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-644?page=all ]
David Crossley updated FOR-644:
-------------------------------
Fix Version/s: 0.8-dev
(was: 0.9)
Scheduling for 0.8 release. We should try this. During the code-freeze for 0.8 release would be a good time, as everybody should have worked their changes into the code by then.
IIRC "tidy" removed the whitespace following an anchor element. If not fixed then we need to post-process the files with that perl script. Need to do the tests again beforehand.
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: http://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-644?page=comments#action_12373576 ]
David Crossley commented on FOR-644:
------------------------------------
Added Perl script etc/tidy-xml.pl and config file to find all xml files and run tidy.sf.net
Test it on etc/test-whitespace/
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: http://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Type: Task
> Components: Other
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Crossley updated FOR-644:
-------------------------------
Fix Version/s: (was: 0.8-dev)
0.9
Affects Version/s: 0.9
Done the whole of trunk for 0.8 release. Moving this issue over to 0.9
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8-dev, 0.9
> Reporter: David Crossley
> Assigned To: David Crossley
> Fix For: 0.9
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487370 ]
David Crossley commented on FOR-644:
------------------------------------
Didn't get around to comparing. Going with xmlformat. I will start processing some of the more obscure areas of our trunk because less likely that people will be still working there. This gets some of the job done early, and the rest will be done just after the code freeze starts.
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8-dev
> Reporter: David Crossley
> Assigned To: David Crossley
> Fix For: 0.8-dev
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-644?page=all ]
David Crossley updated FOR-644:
-------------------------------
Fix Version: 0.9
(was: 0.8-dev)
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: http://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Type: Task
> Components: Other
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.9
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485967 ]
David Crossley commented on FOR-644:
------------------------------------
Last week i have been testing "xmlformat" which concentrates specifically on the formatting task. Its is nice. This week i will compare results.
http://www.kitebird.com/software/xmlformat/
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-644?page=comments#action_12373578 ]
David Crossley commented on FOR-644:
------------------------------------
Not sure if we should add parameter "char-encoding: utf8" to etc/tidy-config.txt file. See the effect that it has on entities in the main test document etc/test-whitespace/test-1.xml
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: http://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Type: Task
> Components: Other
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-644) whitespace cleanup
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-644?page=all ]
Tim Williams updated FOR-644:
-----------------------------
Component: Other
> whitespace cleanup
> ------------------
>
> Key: FOR-644
> URL: http://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Type: Task
> Components: Other
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and see the list at trunk/etc/whitespace-cleanup.txt
> This Issue will be used to announce which section of the repository is due to be cleaned next. Please keep discussion on that mail thread.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-644?page=all ]
David Crossley updated FOR-644:
-------------------------------
Description:
We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
was:
We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: http://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Type: Task
> Components: Other
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487427 ]
David Crossley commented on FOR-644:
------------------------------------
This is great. I tried it on our dtdx plugin, then published our website again. This revealed an issue with xsl stylesheets formatting which collapsed the single space in an <xsl:text> element. xmlformat.conf to the rescue.
So i am going to do similar tests with some of our other more obscure plugins.
Another warning:
If developers do not get their trunk changes contributed/committed, then i expect that you are going to need to move your changed files out of the way before doing 'svn update' after the code-freeze.
In such a case, there is an option for you. Install xmlformat and run our Ant target over your own working copy (thus using the same xmlformat.conf) then check with diff. See main/build.xml r526505.
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8-dev
> Reporter: David Crossley
> Assigned To: David Crossley
> Fix For: 0.8-dev
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861253#action_12861253 ]
David Crossley commented on FOR-644:
------------------------------------
Yes that is correct. Just before release is the ideal time, because all changes should be already committed. We do have some docs about the process.
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8, 0.9-dev
> Reporter: David Crossley
> Fix For: 0.9-dev
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Crossley reassigned FOR-644:
----------------------------------
Assignee: David Crossley
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: https://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Issue Type: Task
> Components: Other
> Affects Versions: 0.8-dev
> Reporter: David Crossley
> Assigned To: David Crossley
> Fix For: 0.8-dev
>
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and http://marc.theaimsgroup.com/?t=112495618800002 and various linked discussions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-644) code-style cleanup for xml files
Posted by "David Crossley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-644?page=all ]
David Crossley updated FOR-644:
-------------------------------
Summary: code-style cleanup for xml files (was: whitespace cleanup)
Description:
We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001
was:
We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001 and see the list at trunk/etc/whitespace-cleanup.txt
This Issue will be used to announce which section of the repository is due to be cleaned next. Please keep discussion on that mail thread.
> code-style cleanup for xml files
> --------------------------------
>
> Key: FOR-644
> URL: http://issues.apache.org/jira/browse/FOR-644
> Project: Forrest
> Type: Task
> Components: Other
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> We have much inconsistent whitespace in all of our files. This is known to cause trouble in a collaborative environment. See discussion at: http://marc.theaimsgroup.com/?t=112450901100001
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira