You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by lt...@apache.org on 2006/11/05 12:12:30 UTC
svn commit: r471398 - in /maven/maven-1/plugins/trunk/scm: plugin.jelly
xdocs/changes.xml
Author: ltheussl
Date: Sun Nov 5 03:12:29 2006
New Revision: 471398
URL: http://svn.apache.org/viewvc?view=rev&rev=471398
Log:
PR: MPSCM-63
Make prepare-release goal fail if project.xml or changes.xml can't be edited.
Modified:
maven/maven-1/plugins/trunk/scm/plugin.jelly
maven/maven-1/plugins/trunk/scm/xdocs/changes.xml
Modified: maven/maven-1/plugins/trunk/scm/plugin.jelly
URL: http://svn.apache.org/viewvc/maven/maven-1/plugins/trunk/scm/plugin.jelly?view=diff&rev=471398&r1=471397&r2=471398
==============================================================================
--- maven/maven-1/plugins/trunk/scm/plugin.jelly (original)
+++ maven/maven-1/plugins/trunk/scm/plugin.jelly Sun Nov 5 03:12:29 2006
@@ -320,12 +320,20 @@
<!-- TODO: verify that the name is valid for a tag -->
<!-- Update project.xml -->
+ <j:set var="pomFilename" value="project.xml" />
+ <util:file var="file" name="${pomFilename}"/>
+ <j:if test="${!file.canWrite()}">
+ <ant:fail>project.xml is not writable!</ant:fail>
+ </j:if>
<t:release-version version="${version_name}" tag="${tag_name}" />
<!-- Update changes.xml if it exists -->
<j:set var="changesFilename" value="${maven.docs.src}/changes.xml" />
<util:file var="file" name="${changesFilename}"/>
<j:if test="${file.exists()}">
+ <j:if test="${!file.canWrite()}">
+ <ant:fail>changes.xml exists but is not writable!</ant:fail>
+ </j:if>
<c:release-version version="${version_name}" />
</j:if>
Modified: maven/maven-1/plugins/trunk/scm/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/maven/maven-1/plugins/trunk/scm/xdocs/changes.xml?view=diff&rev=471398&r1=471397&r2=471398
==============================================================================
--- maven/maven-1/plugins/trunk/scm/xdocs/changes.xml (original)
+++ maven/maven-1/plugins/trunk/scm/xdocs/changes.xml Sun Nov 5 03:12:29 2006
@@ -24,6 +24,7 @@
</properties>
<body>
<release version="1.6.1-SNAPSHOT" date="In SVN">
+ <action dev="ltheussl" type="fix" issue="MPSCM-63">The prepare-release goal should fail if project.xml can't be edited (e.g. read only).</action>
<action dev="ltheussl" type="fix" issue="MPSCM-89">SCM Parse Connection output is wrong / misleading.</action>
<action dev="ltheussl" type="fix" issue="MPSCM-86">scm:prepare-release does not commit modified changes.xml.</action>
<action dev="ltheussl" type="update">Update dom4j and jelly dependencies to match the ones in maven 1.1 core.</action>