You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by st...@duboce.net on 2010/11/10 01:09:21 UTC

Re: Review Request: HBASE-3209 : New Compaction Algorithm

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1192/#review1881
-----------------------------------------------------------

Ship it!


k... let me commit.


trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.cloudera.org/r/1192/#comment6110>

    Whitespace here -- I can fix on commit.



trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
<http://review.cloudera.org/r/1192/#comment6113>

    Very cute


- stack


On 2010-11-09 15:10:57, Nicolas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1192/
> -----------------------------------------------------------
> 
> (Updated 2010-11-09 15:10:57)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> We have a whole bunch of compaction awesome in our internal 0.89 branch. Porting this to 0.90:
> 
> 1) don't unconditionally compact 4 files. have a min threshold
> 2) intelligently upgrade minors to majors
> 3) new compaction algo (derived in HBASE-2462 )
> 
> 
> This addresses bug HBASE-3209.
>     http://issues.apache.org/jira/browse/HBASE-3209
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1033278 
> 
> Diff: http://review.cloudera.org/r/1192/diff
> 
> 
> Testing
> -------
> 
> Has been running on our primary cluster for the past couple weeks.
> 
> 
> Thanks,
> 
> Nicolas
> 
>