You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by jayapalu <gi...@git.apache.org> on 2017/01/02 12:24:05 UTC
[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...
GitHub user jayapalu opened a pull request:
https://github.com/apache/cloudstack/pull/1886
CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response
Url generated by CCP to request traffic sentinel for usage stats is too long causing HTTP 414 Request-URI Too Long error response. This is because we are using the GET request to send the data to the traffic sentinel instance and url size exceeds the max length of GET request.
Changing the request method to POST
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accelerite/cloudstack trafficsentinel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1886
----
commit 021eae4f55f4dba9eb267d68a17893d7f31e0d99
Author: Jayapal <ja...@accelerite.com>
Date: 2017-01-02T10:59:17Z
CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Posted by jayapalu <gi...@git.apache.org>.
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1886
@rafaelweingartner Traffic sentinel supports the post request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Posted by kishankavala <gi...@git.apache.org>.
Github user kishankavala commented on the issue:
https://github.com/apache/cloudstack/pull/1886
Tested manually. Did not see any issues with long list of IPs.
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1886#discussion_r94721965
--- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java ---
@@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer getPublicIpBytesSentAndReceived(DirectNetworkUs
answer.put(publicIp, bytesSentAndReceived);
}
}
+ os.close();
--- End diff --
The input and output streams may not get closed in case of exception, it is better to do any cleanup in the finally block.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1886
@jayapalu you changed the request type to `POST`. Is the server side (the bit that will handle/deliver this request) expecting `POST` requests as well?
Also, how do you feel about extracting the request object creation (lines 214-219) to a specific method? Then, we can document and describe what how the method is supposed to work; it also enabled the writing of test cases (for this request creation method).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...
Posted by jayapalu <gi...@git.apache.org>.
Github user jayapalu commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1886#discussion_r103136343
--- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java ---
@@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer getPublicIpBytesSentAndReceived(DirectNetworkUs
answer.put(publicIp, bytesSentAndReceived);
}
}
+ os.close();
--- End diff --
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1886
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Posted by jayapalu <gi...@git.apache.org>.
Github user jayapalu commented on the issue:
https://github.com/apache/cloudstack/pull/1886
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1886
### ACS CI BVT Run
**Sumarry:**
Build Number 357
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=2
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_routers_network_ops.py
* test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 2 runs
* test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 3 runs
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...
Posted by cloudmonger <gi...@git.apache.org>.
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1886
### ACS CI BVT Run
**Sumarry:**
Build Number 398
Hypervisor xenserver
NetworkType Advanced
Passed=104
Failed=1
Skipped=7
_Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
**Failed tests:**
* test_non_contigiousvlan.py
* test_extendPhysicalNetworkVlan Failing since 2 runs
**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm
**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---