You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/10/14 12:42:26 UTC
[GitHub] [accumulo-testing] ctubbsii opened a new pull request, #245: Standardize formatting of shell scripts
ctubbsii opened a new pull request, #245:
URL: https://github.com/apache/accumulo-testing/pull/245
* Standardize shebang lines for bash scripts
* Run `shfmt -ln bash -l -d -i 2 -ci -s .` to format scripts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii merged pull request #245: Standardize formatting of shell scripts
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #245:
URL: https://github.com/apache/accumulo-testing/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo commented on pull request #245: Standardize formatting of shell scripts
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #245:
URL: https://github.com/apache/accumulo-testing/pull/245#issuecomment-1278989158
These changes look good.
> * Standardize shebang lines for bash scripts
I also noticed there are files that have `#! /bin/bash` instead of `#! /usr/bin/env bash`. Not sure if this is something that should be standardized or if it should be handled here but just wanted to point it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] ctubbsii commented on pull request #245: Standardize formatting of shell scripts
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #245:
URL: https://github.com/apache/accumulo-testing/pull/245#issuecomment-1279012898
> These changes look good.
>
> > * Standardize shebang lines for bash scripts
>
> I also noticed there are files that have `#! /bin/bash` instead of `#! /usr/bin/env bash`. Not sure if this is something that should be standardized or if it should be handled here but just wanted to point it out.
I thought I fixed all those, but it may have missed the terraform template ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org