You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jan Hentschel (JIRA)" <ji...@apache.org> on 2019/05/09 10:43:01 UTC

[jira] [Resolved] (HBASE-22358) Change rubocop configuration for method length

     [ https://issues.apache.org/jira/browse/HBASE-22358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Hentschel resolved HBASE-22358.
-----------------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 1.4.11
                   1.3.5
                   2.2.1
                   2.1.5
                   2.0.6
                   2.3.0
                   1.5.0
                   3.0.0
     Release Note: The rubocop definition for the maximum method length was set to 75.

> Change rubocop configuration for method length
> ----------------------------------------------
>
>                 Key: HBASE-22358
>                 URL: https://issues.apache.org/jira/browse/HBASE-22358
>             Project: HBase
>          Issue Type: Improvement
>          Components: community, shell
>            Reporter: Jan Hentschel
>            Assignee: Murtaza Hassan
>            Priority: Minor
>              Labels: beginner, beginners
>             Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.1.5, 2.2.1, 1.3.5, 1.4.11
>
>
> rubocop currently uses a maximum method length for the Ruby code of 10, which is way too restrictive. In Checkstyle we're using 150 lines per method. Don't know if it needs to be that much, but something between 50 and 75 seems to be more realistic, especially for test cases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)