You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "shoothzj (via GitHub)" <gi...@apache.org> on 2024/04/09 07:06:26 UTC
[PR] feat: allow user config AsyncLogger in log4j2 [bookkeeper]
shoothzj opened a new pull request, #4269:
URL: https://github.com/apache/bookkeeper/pull/4269
### Motivation
Adding lmax disruptor in dependency allow user to config AsyncLogger in log4j2.xml like this
```xml
<Loggers>
<AsyncLogger name="async" level="info">
<AppenderRef ref="AsyncConsole"/>
</AsyncLogger>
</Loggers>
```
See also https://logging.apache.org/log4j/2.x/manual/async.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: allow user config AsyncLogger in log4j2 [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4269:
URL: https://github.com/apache/bookkeeper/pull/4269#issuecomment-2045151226
@nicoloboschi @eolivelli @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: allow user config AsyncLogger in log4j2 [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj merged PR #4269:
URL: https://github.com/apache/bookkeeper/pull/4269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: allow user config AsyncLogger in log4j2 [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on code in PR #4269:
URL: https://github.com/apache/bookkeeper/pull/4269#discussion_r1557202812
##########
pom.xml:
##########
@@ -147,8 +150,6 @@
<junit.version>4.13.2</junit.version>
<hamcrest.version>1.3</hamcrest.version>
<junit5.version>5.10.2</junit5.version>
- <assertj-core.version>3.25.3</assertj-core.version>
- <awaitility.version>4.2.0</awaitility.version>
Review Comment:
@lhotari Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: allow user config AsyncLogger in log4j2 [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4269:
URL: https://github.com/apache/bookkeeper/pull/4269#issuecomment-2046492912
@nicoloboschi @eolivelli @hangc0276 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: allow user config AsyncLogger in log4j2 [bookkeeper]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #4269:
URL: https://github.com/apache/bookkeeper/pull/4269#discussion_r1557198717
##########
pom.xml:
##########
@@ -147,8 +150,6 @@
<junit.version>4.13.2</junit.version>
<hamcrest.version>1.3</hamcrest.version>
<junit5.version>5.10.2</junit5.version>
- <assertj-core.version>3.25.3</assertj-core.version>
- <awaitility.version>4.2.0</awaitility.version>
Review Comment:
I'd suggest to not move these in the same PR. If there's a need to put these in alphabetical order, it's better to do that separately and do it consistently. Currently the testing related libraries are kept together and that's why assertj-core and awaitility versions are after junit5 version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org