[GitHub] judby commented on a change in pull request #192: [MNG-6261] - using java File api to compare

[GitBox <gi...@apache.org>]

judby commented on a change in pull request #192: [MNG-6261] - using java File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r235257910
 
 

 ##########
 File path: maven-model-builder/src/main/java/org/apache/maven/model/building/FileModelSource.java
 ##########
 @@ -80,4 +80,27 @@ public URI getLocationURI()
     {
         return getFile().toURI();
     }
+
+    @Override
+    public boolean equals( Object obj ) 
+    {
+        if ( this == obj ) 
+        {
+            return true;
+        }
+        
+        if ( ( obj == null ) || !( obj instanceof FileModelSource ) ) 
 
 Review comment:
   Compare with null not necessary since `null instanceof FileModelSource` is `false`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services