[GitHub] spark issue #16376: [SPARK-18967][SCHEDULER] compute locality levels even if...

[kayousterhout <gi...@git.apache.org>]

Github user kayousterhout commented on the issue:

    https://github.com/apache/spark/pull/16376
  
    @lirui-intel yes, that's consistent with my understanding.  The TaskSetManager still checks that it's not going beyond the currently-allowed locality level [here](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala#L424), so locality levels > 0 will still be enforced, and the TaskSchedulerImpl is still checking all of the locality levels in myLocalityLevels each time it has an offer, so it will still schedule non-local tasks when the wait is 0 and no local tasks can be scheduled.  Also, my comment above may be helpful for understanding why this bug was originally introduced.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org