You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2020/02/02 19:22:59 UTC

[maven-indexer] 01/01: Remove extra methods on things that aren't closable

This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch pull/43
in repository https://gitbox.apache.org/repos/asf/maven-indexer.git

commit d0ff4ae8a3be54ed1852bdbe38c74df7f95f1f2a
Author: sixcorners <si...@gmail.com>
AuthorDate: Sun Feb 2 09:26:31 2020 -0600

    Remove extra methods on things that aren't closable
    
    Closes #43
---
 .../apache/maven/index/reader/CachingResourceHandler.java    | 12 ------------
 .../org/apache/maven/index/reader/HttpResourceHandler.java   |  4 ----
 2 files changed, 16 deletions(-)

diff --git a/indexer-reader/src/test/java/org/apache/maven/index/reader/CachingResourceHandler.java b/indexer-reader/src/test/java/org/apache/maven/index/reader/CachingResourceHandler.java
index be38b71..d12f96d 100644
--- a/indexer-reader/src/test/java/org/apache/maven/index/reader/CachingResourceHandler.java
+++ b/indexer-reader/src/test/java/org/apache/maven/index/reader/CachingResourceHandler.java
@@ -40,12 +40,6 @@ public class CachingResourceHandler
         {
             return null;
         }
-
-        public void close()
-            throws IOException
-        {
-            // nop
-        }
     };
 
     private final WritableResourceHandler local;
@@ -130,12 +124,6 @@ public class CachingResourceHandler
                 localResource.close();
             }
         }
-
-        public void close()
-            throws IOException
-        {
-            // nop
-        }
     }
 
     public void close()
diff --git a/indexer-reader/src/test/java/org/apache/maven/index/reader/HttpResourceHandler.java b/indexer-reader/src/test/java/org/apache/maven/index/reader/HttpResourceHandler.java
index e9ea16d..e19d949 100644
--- a/indexer-reader/src/test/java/org/apache/maven/index/reader/HttpResourceHandler.java
+++ b/indexer-reader/src/test/java/org/apache/maven/index/reader/HttpResourceHandler.java
@@ -63,10 +63,6 @@ public class HttpResourceHandler
       conn.setRequestProperty("User-Agent", "ASF Maven-Indexer-Reader/1.0");
       return new BufferedInputStream(conn.getInputStream());
     }
-
-    public void close() throws IOException {
-      // nop
-    }
   }
 
   public void close() throws IOException {