You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/10/26 05:31:00 UTC

[jira] [Updated] (ARROW-10325) [C++][Compute] Separate aggregate kernel registration

     [ https://issues.apache.org/jira/browse/ARROW-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated ARROW-10325:
-----------------------------------
    Labels: pull-request-available  (was: )

> [C++][Compute] Separate aggregate kernel registration
> -----------------------------------------------------
>
>                 Key: ARROW-10325
>                 URL: https://issues.apache.org/jira/browse/ARROW-10325
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Yibo Cai
>            Assignee: Yibo Cai
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We have basic aggregate kernel 'count/mean/sum/min_max' implemented in one file (plus simd version) and more complicated 'mode' and 'variance/stddev' kernels implemented in separated files.
> 'mode' and 'variance/stddev' kernels are now registered together with basic kernels in aggregate_basic.cc. And there are 'mode' and 'variance/stddev' kernel related function definitions in aggregate_basic_internal.h.
> This is not good. They should be moved from basic kernel source to their own implementation files and registered separately.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)