You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "gsmiller (via GitHub)" <gi...@apache.org> on 2023/10/09 18:32:07 UTC
[PR] Add javadoc note to LeafCollector#finish [lucene]
gsmiller opened a new pull request, #12643:
URL: https://github.com/apache/lucene/pull/12643
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add javadoc note to LeafCollector#finish [lucene]
Posted by "gf2121 (via GitHub)" <gi...@apache.org>.
gf2121 commented on code in PR #12643:
URL: https://github.com/apache/lucene/pull/12643#discussion_r1351629111
##########
lucene/core/src/java/org/apache/lucene/search/LeafCollector.java:
##########
@@ -125,6 +125,8 @@ default DocIdSetIterator competitiveIterator() throws IOException {
* is typically useful to compile data that has been collected on this leaf, e.g. to convert facet
* counts on leaf ordinals to facet counts on global ordinals. The default implementation does
* nothing.
+ *
+ * <p>Note: It can be assumed that this method will only be called once per LeafCollector instance
Review Comment:
```suggestion
* <p>Note: It can be assumed that this method will only be called once per LeafCollector instance.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add javadoc note to LeafCollector#finish [lucene]
Posted by "gsmiller (via GitHub)" <gi...@apache.org>.
gsmiller merged PR #12643:
URL: https://github.com/apache/lucene/pull/12643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org